Sign upLogin

Kharouk/CameronCam

View on GitHub
Star

Showing 8 of 10 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  handleRegisterSubmit = event => {
    event.preventDefault();
    const { email, password } = this.state;
    firebase
      .auth()
Severity: Major
Found in src/App.js and 1 other location - About 5 hrs to fix
src/App.js on lines 119..134

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 154.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  handleLoginSubmit = event => {
    event.preventDefault();
    const { email, password } = this.state;
    firebase
      .auth()
Severity: Major
Found in src/App.js and 1 other location - About 5 hrs to fix
src/App.js on lines 51..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 154.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File MapComponent.js has 291 lines of code (exceeds 250 allowed). Consider refactoring.
Confirmed

import React, { Component, useState } from "react";
import Button from "./Button";
import ImageUpload from "./ImageUpload";
import Description from "./Description";
import {
Severity: Minor
Found in src/components/MapComponent.js - About 3 hrs to fix

    Function SocialLinks has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Confirmed

    const SocialLinks = marker => {
  const [city, setCity] = useState(null);
  const [quote, setQuote] = useState(null);
  Geocode.fromLatLng(marker.lat, marker.lng).then(
    response => {
    Severity: Major
    Found in src/components/MapComponent.js - About 2 hrs to fix

      Function render has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Confirmed

        render() {
    return (
      <div id="map">
        <MapComponent
          lat={51.52713}
      Severity: Minor
      Found in src/components/MapComponent.js - About 1 hr to fix

        Function Button has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const Button = props => {
  if (props.isSaveButton) {
    color = "rgb(63, 130, 195)";
    onClick = props.saveToDatabase;
    margin = "0";
        Severity: Minor
        Found in src/components/Button.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          <input
                  type="text"
                  name="email"
                  className="input__fields"
                  placeholder="Email"
          Severity: Minor
          Found in src/components/Login.js and 1 other location - About 35 mins to fix
          src/components/Login.js on lines 92..100

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          <input
                  type="text"
                  name="email"
                  className="input__fields"
                  placeholder="Email"
          Severity: Minor
          Found in src/components/Login.js and 1 other location - About 35 mins to fix
          src/components/Login.js on lines 142..150

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language