Sign upLogin

Kinvey/js-sdk

View on GitHub
Star
packages/js-sdk/src/datastore/networkstore.ts

Summary

Maintainability
D
2 days
Test Coverage

File networkstore.ts has 335 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { isArray, cloneDeep } from 'lodash-es';
import { Observable } from 'rxjs';
import { getDeviceId } from '../device';
import { Aggregation } from '../aggregation';
import { Query } from '../query';
Severity: Minor
Found in packages/js-sdk/src/datastore/networkstore.ts - About 4 hrs to fix

    Function create has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async create(docs: any, options: any = {}) {
    const batchSize = 100;
    const apiVersion = getApiVersion();

    if (isArray(docs)) {
    Severity: Minor
    Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

      Function findById has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        findById(id: string, options: any = {}) {
    const stream = Observable.create(async (observer: any) => {
      try {
        // if (!id) {
        //   throw new Error('No id was provided. A valid id is required.');
      Severity: Minor
      Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

        Function create has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          async create(docs: any, options: any = {}) {
    const batchSize = 100;
    const apiVersion = getApiVersion();

    if (isArray(docs)) {
        Severity: Minor
        Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function find has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          find(query?: Query, options: any = {}) {
    const stream = Observable.create(async (observer: any) => {
      try {
        if (query && !(query instanceof Query)) {
          throw new KinveyError('Invalid query. It must be an instance of the Query class.');
        Severity: Minor
        Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

          Function group has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            group(aggregation: Aggregation, options: any = {}) {
    const stream = Observable.create(async (observer: any) => {
      try {
        if (!(aggregation instanceof Aggregation)) {
          throw new KinveyError('Invalid aggregation. It must be an instance of the Aggregation class.');
          Severity: Minor
          Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

            Function count has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              count(query?: Query, options: any = {}) {
    const stream = Observable.create(async (observer: any) => {
      try {
        if (query && !(query instanceof Query)) {
          throw new KinveyError('Invalid query. It must be an instance of the Query class.');
            Severity: Minor
            Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

              Function stream has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  const stream = Observable.create(async (observer: any) => {
      try {
        // if (!id) {
        //   throw new Error('No id was provided. A valid id is required.');
        // }
              Severity: Minor
              Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

                Function stream has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    const stream = Observable.create(async (observer: any) => {
      try {
        if (query && !(query instanceof Query)) {
          throw new KinveyError('Invalid query. It must be an instance of the Query class.');
        }
                Severity: Minor
                Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

                  Function find has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    find(query?: Query, options: any = {}) {
    const stream = Observable.create(async (observer: any) => {
      try {
        if (query && !(query instanceof Query)) {
          throw new KinveyError('Invalid query. It must be an instance of the Query class.');
                  Severity: Minor
                  Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function count has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                    count(query?: Query, options: any = {}) {
    const stream = Observable.create(async (observer: any) => {
      try {
        if (query && !(query instanceof Query)) {
          throw new KinveyError('Invalid query. It must be an instance of the Query class.');
                  Severity: Minor
                  Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function stream has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      const stream = Observable.create(async (observer: any) => {
      try {
        if (query && !(query instanceof Query)) {
          throw new KinveyError('Invalid query. It must be an instance of the Query class.');
        }
                  Severity: Minor
                  Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

                    Function stream has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        const stream = Observable.create(async (observer: any) => {
      try {
        if (!(aggregation instanceof Aggregation)) {
          throw new KinveyError('Invalid aggregation. It must be an instance of the Aggregation class.');
        }
                    Severity: Minor
                    Found in packages/js-sdk/src/datastore/networkstore.ts - About 1 hr to fix

                      Function findById has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                      Open

                        findById(id: string, options: any = {}) {
    const stream = Observable.create(async (observer: any) => {
      try {
        // if (!id) {
        //   throw new Error('No id was provided. A valid id is required.');
                      Severity: Minor
                      Found in packages/js-sdk/src/datastore/networkstore.ts - About 55 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function group has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                        group(aggregation: Aggregation, options: any = {}) {
    const stream = Observable.create(async (observer: any) => {
      try {
        if (!(aggregation instanceof Aggregation)) {
          throw new KinveyError('Invalid aggregation. It must be an instance of the Aggregation class.');
                      Severity: Minor
                      Found in packages/js-sdk/src/datastore/networkstore.ts - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              const {
          rawResponse = false,
          timeout,
          properties,
          trace,
                      Severity: Minor
                      Found in packages/js-sdk/src/datastore/networkstore.ts and 1 other location - About 35 mins to fix
                      packages/js-sdk/src/datastore/networkstore.ts on lines 163..171

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 47.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                const {
            rawResponse = false,
            timeout,
            properties,
            trace,
                      Severity: Minor
                      Found in packages/js-sdk/src/datastore/networkstore.ts and 1 other location - About 35 mins to fix
                      packages/js-sdk/src/datastore/networkstore.ts on lines 55..63

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 47.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status