Sign upLogin

Kinvey/js-sdk

View on GitHub
Star
packages/js-sdk/src/http/headers.ts

Summary

Maintainability
D
2 days
Test Coverage

Function setAuthorization has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

  async setAuthorization(auth: KinveyHttpAuth): Promise<void> {
    const appKey = getAppKey();
    const appSecret = getAppSecret();
    const masterSecret = getMasterSecret();
    const session = await getSession();
Severity: Minor
Found in packages/js-sdk/src/http/headers.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setAuthorization has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async setAuthorization(auth: KinveyHttpAuth): Promise<void> {
    const appKey = getAppKey();
    const appSecret = getAppSecret();
    const masterSecret = getMasterSecret();
    const session = await getSession();
Severity: Major
Found in packages/js-sdk/src/http/headers.ts - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

          if (!mfaSessionToken) {
        throw new KinveyError('Missing MFA session token to authorize the request.');
      }
    Severity: Major
    Found in packages/js-sdk/src/http/headers.ts - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

          } else if (auth === KinveyHttpAuth.All) {
      try {
        return await this.setAuthorization(KinveyHttpAuth.Session);
      } catch (error) {
        try {
      Severity: Major
      Found in packages/js-sdk/src/http/headers.ts - About 45 mins to fix

        Avoid too many return statements within this function.
        Open

                  return await this.setAuthorization(KinveyHttpAuth.Master);
        Severity: Major
        Found in packages/js-sdk/src/http/headers.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return await this.setAuthorization(KinveyHttpAuth.Master);
          Severity: Major
          Found in packages/js-sdk/src/http/headers.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return await this.setAuthorization(KinveyHttpAuth.Session);
            Severity: Major
            Found in packages/js-sdk/src/http/headers.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return await this.setAuthorization(KinveyHttpAuth.Session);
              Severity: Major
              Found in packages/js-sdk/src/http/headers.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return await this.setAuthorization(KinveyHttpAuth.App);
                Severity: Major
                Found in packages/js-sdk/src/http/headers.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                            return await this.setAuthorization(KinveyHttpAuth.MFASessionToken);
                  Severity: Major
                  Found in packages/js-sdk/src/http/headers.ts - About 30 mins to fix

                    Function byteCount has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function byteCount(str: string): number {
  if (str) {
    let count = 0;
    const stringLength = str.length;
                    Severity: Minor
                    Found in packages/js-sdk/src/http/headers.ts - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        } else if (auth === KinveyHttpAuth.SessionOrMFASessionTokenOrMaster) {
      try {
        return await this.setAuthorization(KinveyHttpAuth.Session);
      } catch (error) {
        try {
                    Severity: Major
                    Found in packages/js-sdk/src/http/headers.ts and 1 other location - About 2 hrs to fix
                    packages/js-sdk/src/http/headers.ts on lines 187..219

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 81.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        } else if (auth === KinveyHttpAuth.All) {
      try {
        return await this.setAuthorization(KinveyHttpAuth.Session);
      } catch (error) {
        try {
                    Severity: Major
                    Found in packages/js-sdk/src/http/headers.ts and 1 other location - About 2 hrs to fix
                    packages/js-sdk/src/http/headers.ts on lines 209..219

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 81.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (auth === KinveyHttpAuth.App) {
      if (!appKey || !appSecret) {
        throw new KinveyError('Missing appKey and/or appSecret to authorize the request.');
      }
      const credentials = Base64.encode(`${appKey}:${appSecret}`);
                    Severity: Major
                    Found in packages/js-sdk/src/http/headers.ts and 1 other location - About 1 hr to fix
                    packages/js-sdk/src/http/headers.ts on lines 171..219

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 70.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        } else if (auth === KinveyHttpAuth.Master) {
      if (!appKey || !masterSecret) {
        throw new KinveyError('Missing appKey and/or masterSecret to authorize the request.');
      }
      const credentials = Base64.encode(`${appKey}:${masterSecret}`);
                    Severity: Major
                    Found in packages/js-sdk/src/http/headers.ts and 1 other location - About 1 hr to fix
                    packages/js-sdk/src/http/headers.ts on lines 165..219

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 70.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        } else if (auth === KinveyHttpAuth.SessionOrApp) {
      try {
        return await this.setAuthorization(KinveyHttpAuth.Session);
      } catch (error) {
        return await this.setAuthorization(KinveyHttpAuth.App);
                    Severity: Minor
                    Found in packages/js-sdk/src/http/headers.ts and 1 other location - About 50 mins to fix
                    packages/js-sdk/src/http/headers.ts on lines 203..219

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 51.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        } else if (auth === KinveyHttpAuth.SessionOrMaster) {
      try {
        return await this.setAuthorization(KinveyHttpAuth.Session);
      } catch (error) {
        return await this.setAuthorization(KinveyHttpAuth.Master);
                    Severity: Minor
                    Found in packages/js-sdk/src/http/headers.ts and 1 other location - About 50 mins to fix
                    packages/js-sdk/src/http/headers.ts on lines 197..219

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 51.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status