Sign upLogin

KnapsackPro/knapsack_pro-ruby

View on GitHub
Star

Showing 33 of 33 total issues

Method group_test_files_by_directory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def group_test_files_by_directory
      sorted_test_files.each do |test_file|
        found = false
        DIR_TYPES.each do |type|
          if test_file['path'].match(/#{type}/)
Severity: Minor
Found in lib/knapsack_pro/test_flat_distributor.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return 'Buddy.works' if ENV.key?('BUDDY')
Severity: Major
Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

              return 'TeamCity' if ENV.key?('TEAMCITY_VERSION')
    Severity: Major
    Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return 'Other' if KnapsackPro::Config::Env.ci?
      Severity: Major
      Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                  return 'Jenkins' if ENV.key?('JENKINS_URL')
        Severity: Major
        Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return 'Google Cloud Build' if ENV.key?('BUILDER_OUTPUT')
          Severity: Major
          Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                      return 'Drone.io' if ENV.key?('DRONE')
            Severity: Major
            Found in lib/knapsack_pro/config/ci/base.rb - About 30 mins to fix

              Method add_knapsack_pro_formatters_to has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      def add_knapsack_pro_formatters_to(spec_opts)
          return spec_opts unless spec_opts
          return spec_opts if FORMATTERS.all? { |formatter| spec_opts.include?(formatter) }

          FORMATTERS.each do |formatter|
              Severity: Minor
              Found in lib/knapsack_pro/pure/queue/rspec_pure.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method test_files has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def test_files
      if test_file_list_enabled && KnapsackPro::Config::Env.test_file_list
        return KnapsackPro::Config::Env.test_file_list.split(',').map(&:strip)
      end
              Severity: Minor
              Found in lib/knapsack_pro/test_file_finder.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run_startup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      def run_startup(result)
          return if @test_case.nil?
          KnapsackPro.tracker.current_test_path = KnapsackPro::Adapters::TestUnitAdapter.test_path(self)
          KnapsackPro.tracker.start_timer
          return if !@test_case.respond_to?(:startup)
              Severity: Minor
              Found in lib/knapsack_pro/adapters/test_unit_adapter.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method run_shutdown has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                      def run_shutdown(result)
          return if @test_case.nil?
          KnapsackPro.tracker.stop_timer
          return if !@test_case.respond_to?(:shutdown)
          begin
              Severity: Minor
              Found in lib/knapsack_pro/adapters/test_unit_adapter.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      message = "knapsack_pro gem could not connect to Knapsack Pro API and the Fallback Mode cannot be used this time. Running tests in Fallback Mode are not allowed for retried parallel CI node to avoid running the wrong set of tests. Please manually retry this parallel job on your CI server then knapsack_pro gem will try to connect to Knapsack Pro API again and will run a correct set of tests for this CI node. Learn more #{KnapsackPro::Urls::QUEUE_MODE__CONNECTION_ERROR_WITH_FALLBACK_ENABLED_TRUE_AND_POSITIVE_RETRY_COUNT}"
        unless KnapsackPro::Config::Env.fixed_queue_split?
          message += " Please ensure you have set KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true to allow Knapsack Pro API remember the recorded CI node tests so when you retry failed tests on the CI node then the same set of tests will be executed. See more #{KnapsackPro::Urls::FIXED_QUEUE_SPLIT}"
        end
        KnapsackPro.logger.error(message)
              Severity: Minor
              Found in lib/knapsack_pro/queue_allocator.rb and 1 other location - About 15 mins to fix
              lib/knapsack_pro/allocator.rb on lines 34..39

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      message = "knapsack_pro gem could not connect to Knapsack Pro API and the Fallback Mode cannot be used this time. Running tests in Fallback Mode are not allowed for retried parallel CI node to avoid running the wrong set of tests. Please manually retry this parallel job on your CI server then knapsack_pro gem will try to connect to Knapsack Pro API again and will run a correct set of tests for this CI node. Learn more #{KnapsackPro::Urls::REGULAR_MODE__CONNECTION_ERROR_WITH_FALLBACK_ENABLED_TRUE_AND_POSITIVE_RETRY_COUNT}"
        unless KnapsackPro::Config::Env.fixed_test_suite_split?
          message += " Please ensure you have set KNAPSACK_PRO_FIXED_TEST_SUITE_SPLIT=true to allow Knapsack Pro API remember the recorded CI node tests so when you retry failed tests on the CI node then the same set of tests will be executed. See more #{KnapsackPro::Urls::FIXED_TEST_SUITE_SPLIT}"
        end
        KnapsackPro.logger.error(message)
              Severity: Minor
              Found in lib/knapsack_pro/allocator.rb and 1 other location - About 15 mins to fix
              lib/knapsack_pro/queue_allocator.rb on lines 36..41

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 26.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language