kotti/views/cache.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function set_max_age has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def set_max_age(response, delta, cache_ctrl=None):
    """Sets max-age and expires headers based on the timedelta `delta`.

    If `cache_ctrl` is not None, I'll add items found therein to the
    Cache-Control header.
Severity: Minor
Found in kotti/views/cache.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return "Cache Media Content"
Severity: Major
Found in kotti/views/cache.py - About 30 mins to fix

    Function default_caching_policy_chooser has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def default_caching_policy_chooser(context, request, response):
        if request.method != "GET" or response.status_int != 200:
            return None
        elif isinstance(response, FileResponse):
            return "Cache Resource"
    Severity: Minor
    Found in kotti/views/cache.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function set_cache_headers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def set_cache_headers(event):
        request, response = event.request, event.response
    
        # this can happen if a Pyramid tween will shortcut the normal tween
        # chain processing and return its own response early
    Severity: Minor
    Found in kotti/views/cache.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status