Sign upLogin

Krauza/webservice

View on GitHub
Star

Showing 23 of 23 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace Krauza\Infrastructure\Api\Type\Object;

use Krauza\Infrastructure\Api\Type\BaseType;
Severity: Major
Found in src/Infrastructure/Api/Type/Object/CreateCardType.php and 2 other locations - About 1 hr to fix
src/Infrastructure/Api/Type/Object/AddAnswerType.php on lines 1..35
src/Infrastructure/Api/Type/Object/GetNextCardType.php on lines 1..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace Krauza\Infrastructure\Api\Type\Object;

use Krauza\Infrastructure\Api\Type\BaseType;
Severity: Major
Found in src/Infrastructure/Api/Type/Object/AddAnswerType.php and 2 other locations - About 1 hr to fix
src/Infrastructure/Api/Type/Object/CreateCardType.php on lines 1..33
src/Infrastructure/Api/Type/Object/GetNextCardType.php on lines 1..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace Krauza\Infrastructure\Api\Type\Object;

use Krauza\Infrastructure\Api\Type\BaseType;
Severity: Major
Found in src/Infrastructure/Api/Type/Object/GetNextCardType.php and 2 other locations - About 1 hr to fix
src/Infrastructure/Api/Type/Object/AddAnswerType.php on lines 1..35
src/Infrastructure/Api/Type/Object/CreateCardType.php on lines 1..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 113.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method config has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function config(): array
    {
        return [
            'type' => AddAnswerType::getInstance(),
            'description' => 'Add answer for the card',
Severity: Minor
Found in src/Infrastructure/Api/Type/Mutation/AddAnswer.php - About 1 hr to fix

    Missing class import via use statement (line '24', column '43').
    Open

                throw new ValueIsTooLong((new \ReflectionClass($this))->getShortName());
    Severity: Minor
    Found in src/Core/ValueObject/CardWord.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '37', column '44').
    Open

                throw new ValueIsTooShort((new \ReflectionClass($this))->getShortName());
    Severity: Minor
    Found in src/Core/ValueObject/UserName.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '20', column '44').
    Open

                throw new ValueIsTooShort((new \ReflectionClass($this))->getShortName());
    Severity: Minor
    Found in src/Core/ValueObject/CardWord.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '41', column '43').
    Open

                throw new ValueIsTooLong((new \ReflectionClass($this))->getShortName());
    Severity: Minor
    Found in src/Core/ValueObject/UserName.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '30', column '43').
    Open

                throw new ValueIsTooLong((new \ReflectionClass($this))->getShortName());
    Severity: Minor
    Found in src/Core/ValueObject/BoxName.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '45', column '23').
    Open

                throw new \Exception();
    Severity: Minor
    Found in src/Infrastructure/DataAccess/BoxRepository.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '28', column '47').
    Open

                throw new ValueHasWrongChars((new \ReflectionClass($this))->getShortName());
    Severity: Minor
    Found in src/Core/ValueObject/UserName.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '16', column '48').
    Open

                throw new ValueHasWrongFormat((new \ReflectionClass($this))->getShortName());
    Severity: Minor
    Found in src/Core/ValueObject/UserEmail.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '26', column '44').
    Open

                throw new ValueIsTooShort((new \ReflectionClass($this))->getShortName());
    Severity: Minor
    Found in src/Core/ValueObject/BoxName.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid unused parameters such as '$fromSection'.
    Open

        public function moveCardBetweenBoxSections(Box $box, Card $card, int $fromSection, int $toSection): void
    Severity: Minor
    Found in src/Infrastructure/DataAccess/BoxSectionsRepository.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$rootValue'.
    Open

                'resolve' => function ($rootValue, $args, $context) {
    Severity: Minor
    Found in src/Infrastructure/Api/Type/Query/GetUserBoxes.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$rootValue'.
    Open

                'resolve' => function ($rootValue, $args, $context) {
    Severity: Minor
    Found in src/Infrastructure/Api/Type/Query/GetBox.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$rootValue'.
    Open

                'resolve' => function ($rootValue, $args, $context) {
    Severity: Minor
    Found in src/Infrastructure/Api/Type/Mutation/CreateBox.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$rootValue'.
    Open

                'resolve' => function ($rootValue, $args, $context) {
    Severity: Minor
    Found in src/Infrastructure/Api/Type/Query/GetNextCard.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$rootValue'.
    Open

                'resolve' => function($rootValue, $args, $context) {
    Severity: Minor
    Found in src/Infrastructure/Api/Type/Mutation/AddAnswer.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Avoid unused parameters such as '$rootValue'.
    Open

                'resolve' => function ($rootValue, $args, $context) {
    Severity: Minor
    Found in src/Infrastructure/Api/Type/Mutation/CreateCard.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    Severity
    Category
    Status
    Source
    Language