Sign upLogin

Kronos-Integration/kronos-adapter-inbound-file

View on GitHub
Star

Showing 12 of 12 total issues

Function finalize has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    finalize(manager, stepConfiguration) {
        const self = this;
        const inEndpoint = self.endpoints.inFileTrigger;

        let generatorInitialized = false;
Severity: Minor
Found in lib/adapter-inbound-file.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _start has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    _start() {
        const self = this;
        if (self.watchDir) {
            let opt = {};
            if (self.onlyReadNewFiles) {
Severity: Minor
Found in lib/adapter-inbound-file.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function finalize has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    finalize(manager, stepConfiguration) {
        const self = this;
        const inEndpoint = self.endpoints.inFileTrigger;

        let generatorInitialized = false;
Severity: Major
Found in lib/adapter-inbound-file.js - About 2 hrs to fix

    Function receive has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            inEndpoint.receive = function (message) {

            return new Promise(function (fulfill, reject) {
                if (message.payload) {
                    if (typeof message.payload === 'string') {
    Severity: Major
    Found in lib/adapter-inbound-file.js - About 2 hrs to fix

      Function _parseInboundFileMessage has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _parseInboundFileMessage(directory, fileName, message) {
        let fileAbs;
        let fileDir;
        let fileRel;
      Severity: Minor
      Found in lib/adapter-inbound-file.js - About 1 hr to fix

        Function initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            initialize(manager, name, stepConfiguration, props) {

        // A regular expression. The file name must match this expression
        let regEx;
        if (stepConfiguration.regEx) {
        Severity: Minor
        Found in lib/adapter-inbound-file.js - About 1 hr to fix

          Function _start has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              _start() {
        const self = this;
        if (self.watchDir) {
            let opt = {};
            if (self.onlyReadNewFiles) {
          Severity: Minor
          Found in lib/adapter-inbound-file.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                        if (Array.isArray(message.payload.files)) {

                                const promises = [];

                                for (let i = 0; i < message.payload.files.length; i++) {
            Severity: Major
            Found in lib/adapter-inbound-file.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                          if (message.payload.directory) {
                                directory = message.payload.directory;
                            }
              Severity: Major
              Found in lib/adapter-inbound-file.js - About 45 mins to fix

                Function initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    initialize(manager, name, stepConfiguration, props) {

        // A regular expression. The file name must match this expression
        let regEx;
        if (stepConfiguration.regEx) {
                Severity: Minor
                Found in lib/adapter-inbound-file.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                    } else if (typeof message.payload === 'object') {
                        if (message.payload.files) {
                            let directory;
                            if (message.payload.directory) {
                                directory = message.payload.directory;
                Severity: Minor
                Found in lib/adapter-inbound-file.js and 1 other location - About 30 mins to fix
                lib/adapter-inbound-file.js on lines 141..200

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                                if (message.payload) {
                    if (typeof message.payload === 'string') {
                        // take the payload as a single file name
                        fulfill(self._parseInboundFileMessage(undefined, message.payload, message));
                    } else if (Array.isArray(message.payload)) {
                Severity: Minor
                Found in lib/adapter-inbound-file.js and 1 other location - About 30 mins to fix
                lib/adapter-inbound-file.js on lines 156..191

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language