Ks89/angular-modal-gallery

View on GitHub
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 8 locations. Consider refactoring.
Open

const IMAGES: Image[] = [
  new Image(0, {
    // modal
    img: '../assets/images/gallery/img1.jpg',
    extUrl: 'http://www.google.com'
projects/ks89/angular-modal-gallery/src/lib/components/current-image/current-image.component.spec.ts on lines 209..253
projects/ks89/angular-modal-gallery/src/lib/components/dots/dots.component.spec.ts on lines 41..85
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/attach-to-overlay.service.spec.ts on lines 13..57
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery.component.spec.ts on lines 76..120
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery.service.spec.ts on lines 50..94
projects/ks89/angular-modal-gallery/src/lib/components/plain-gallery/plain-gallery.component.spec.ts on lines 55..99
projects/ks89/angular-modal-gallery/src/lib/components/previews/previews.component.spec.ts on lines 76..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 149.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  describe('#emitHasData()', () => {
    it(`should call emitHasData`, () => {
      ref.hasData$.subscribe((event: ImageModalEvent) => {
        expect(EVENT).toEqual(event);
      });
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 107..114
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 116..123
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 125..132
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 134..141
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 152..159
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 161..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  describe('#emitLastImage()', () => {
    it(`should call emitLastImage`, () => {
      ref.lastImage$.subscribe((event: ImageModalEvent) => {
        expect(EVENT).toEqual(event);
      });
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 107..114
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 116..123
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 125..132
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 143..150
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 152..159
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 161..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  describe('#emitShow()', () => {
    it(`should call emitShow`, () => {
      ref.show$.subscribe((event: ImageModalEvent) => {
        expect(EVENT).toEqual(event);
      });
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 107..114
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 125..132
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 134..141
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 143..150
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 152..159
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 161..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  describe('#emitFirstImage()', () => {
    it(`should call emitFirstImage`, () => {
      ref.firstImage$.subscribe((event: ImageModalEvent) => {
        expect(EVENT).toEqual(event);
      });
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 107..114
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 116..123
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 134..141
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 143..150
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 152..159
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 161..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  describe('#emitButtonAfterHook()', () => {
    it(`should call emitButtonAfterHook`, () => {
      ref.buttonAfterHook$.subscribe((event: ButtonEvent) => {
        expect(BTNEVENT).toEqual(event);
      });
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 107..114
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 116..123
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 125..132
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 134..141
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 143..150
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 152..159

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  describe('#emitButtonBeforeHook()', () => {
    it(`should call emitButtonBeforeHook`, () => {
      ref.buttonBeforeHook$.subscribe((event: ButtonEvent) => {
        expect(BTNEVENT).toEqual(event);
      });
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 107..114
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 116..123
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 125..132
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 134..141
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 143..150
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 161..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  describe('#emitClose()', () => {
    it(`should call emitClose`, () => {
      ref.close$.subscribe((event: ImageModalEvent) => {
        expect(EVENT).toEqual(event);
      });
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 116..123
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 125..132
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 134..141
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 143..150
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 152..159
projects/ks89/angular-modal-gallery/src/lib/components/modal-gallery/modal-gallery-ref.spec.ts on lines 161..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status