Sign upLogin

KumbiaPHP/ActiveRecord

View on GitHub
Star

Showing 5 of 5 total issues

BaseRecord has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class BaseRecord
{
    
    public const VERSION = '0.5.8';
Severity: Minor
Found in BaseRecord.php - About 2 hrs to fix

    ActiveRecord has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ActiveRecord extends LiteRecord implements \JsonSerializable
{
    const BELONG_TO = 1;
    const HAS_MANY = 2;
    const HAS_ONE = 3;
    Severity: Minor
    Found in ActiveRecord.php - About 2 hrs to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct(string $model, string $sql, int $page, int $perPage, array $values = [])
      Severity: Minor
      Found in Paginator.php - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static function hasMany($name, $class, $via = null)
    {
        $str = strtolower($name);
        $name = static::getTable();
        static::$relations[$str] = (object) [
        Severity: Minor
        Found in ActiveRecord.php and 1 other location - About 30 mins to fix
        ActiveRecord.php on lines 60..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public static function hasOne($name, $class, $via = null)
    {
        $str = strtolower($name);
        $name = static::getTable();
        static::$relations[$str] = (object) [
        Severity: Minor
        Found in ActiveRecord.php and 1 other location - About 30 mins to fix
        ActiveRecord.php on lines 49..58

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language