Sign upLogin

KumbiaPHP/KumbiaPHP

View on GitHub
Star
core/libs/upload/adapters/image_upload.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function _validates has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    protected function _validates()
    {
        // Verifica que se pueda escribir en el directorio
        if (!is_writable($this->_path)) {
            Flash::error('Error: no se puede escribir en el directorio');
Severity: Minor
Found in core/libs/upload/adapters/image_upload.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _validates has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _validates()
    {
        // Verifica que se pueda escribir en el directorio
        if (!is_writable($this->_path)) {
            Flash::error('Error: no se puede escribir en el directorio');
Severity: Minor
Found in core/libs/upload/adapters/image_upload.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                    return FALSE;
    Severity: Major
    Found in core/libs/upload/adapters/image_upload.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return FALSE;
      Severity: Major
      Found in core/libs/upload/adapters/image_upload.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return parent::_validates();
        Severity: Major
        Found in core/libs/upload/adapters/image_upload.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status