KyivKrishnaAcademy/ved_akadem_students

View on GitHub
client/app/bundles/advanced-search/containers/advanced-search.jsx

Summary

Maintainability
C
1 day
Test Coverage

File advanced-search.jsx has 255 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import qs from 'qs';
import pipe from 'pipe-functions';
import React, { PropTypes } from 'react';

import bindAll from '../../../lib/helpers/bind-all';
Severity: Minor
Found in client/app/bundles/advanced-search/containers/advanced-search.jsx - About 2 hrs to fix

    Function _shownFilters has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _shownFilters() {
        const searchState = this.state.search;
        const configs = this.props.filters;
    
        // Skipping gaps in the ids series
    Severity: Major
    Found in client/app/bundles/advanced-search/containers/advanced-search.jsx - About 2 hrs to fix

      Function _initDefaultFilters has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _initDefaultFilters(state) {
          const config = this.props.filters;
          const searchQuery = state.urlQuery.search || [];
          const searchState = {};
          const firstValues = Object.fromEntries(
      Severity: Minor
      Found in client/app/bundles/advanced-search/containers/advanced-search.jsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                case 'general-search':
                  return (
                    <GeneralSearch
                      key={id}
                      buttons={this.props.buttons}
        client/app/bundles/advanced-search/containers/advanced-search.jsx on lines 146..157

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                case 'text':
                  return (
                    <TextSearch
                      key={id}
                      buttons={this.props.buttons}
        client/app/bundles/advanced-search/containers/advanced-search.jsx on lines 134..145

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 86.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status