src/Admin/Pages/Databases.php
Function page has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring. Open
Open
public static function page()
{
$page = Page::html();
$get = $page->request->query->all();
if ($page->get('adminer') == 'css') {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method page has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public static function page()
{
$page = Page::html();
$get = $page->request->query->all();
if ($page->get('adminer') == 'css') {Consider simplifying this complex logical expression. Open
Open
if (isset($get['file']) || (isset($get['db']) && (isset($get['mssql']) || isset($get['server']) || isset($get['sqlite']) || isset($get['oracle']) || isset($get['pgsql'])))) {
include 'databases/adminer_object.php';
include 'databases/adminer-4.2.5-en.php';
exit;
}The method page() contains an exit expression. Open
Open
exit;- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}