Kylob/BootPress

View on GitHub
src/Admin/Pages/Themes.php

Summary

Maintainability
D
1 day
Test Coverage

Function theme has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    private static function theme($folder)
    {
        extract(Admin::params('bp', 'page', 'blog'));
        if ($page->get('delete') == 'theme') {
            list($dirs, $files) = Files::iterate($folder, 'recursive');
Severity: Minor
Found in src/Admin/Pages/Themes.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method theme has 118 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function theme($folder)
    {
        extract(Admin::params('bp', 'page', 'blog'));
        if ($page->get('delete') == 'theme') {
            list($dirs, $files) = Files::iterate($folder, 'recursive');
Severity: Major
Found in src/Admin/Pages/Themes.php - About 4 hrs to fix

    Method create has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function create()
        {
            $html = '';
            extract(Admin::params('bp', 'page', 'blog'));
            $form = $bp->form('admin_theme_create');
    Severity: Minor
    Found in src/Admin/Pages/Themes.php - About 1 hr to fix

      Method page has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function page()
          {
              extract(Admin::params('page', 'blog', 'bp'));
              if ($edit = $page->get('edit')) {
                  // enforce only one folder path ie. no subfolders
      Severity: Minor
      Found in src/Admin/Pages/Themes.php - About 1 hr to fix

        Function create has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            private static function create()
            {
                $html = '';
                extract(Admin::params('bp', 'page', 'blog'));
                $form = $bp->form('admin_theme_create');
        Severity: Minor
        Found in src/Admin/Pages/Themes.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function page has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function page()
            {
                extract(Admin::params('page', 'blog', 'bp'));
                if ($edit = $page->get('edit')) {
                    // enforce only one folder path ie. no subfolders
        Severity: Minor
        Found in src/Admin/Pages/Themes.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The method theme() contains an exit expression.
        Open

                    exit;
        Severity: Minor
        Found in src/Admin/Pages/Themes.php by phpmd

        ExitExpression

        Since: 0.2

        An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

        Example

        class Foo {
            public function bar($param)  {
                if ($param === 42) {
                    exit(23);
                }
            }
        }

        Source https://phpmd.org/rules/design.html#exitexpression

        There are no issues that match your filters.

        Category
        Status