Function theme
has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring. Open
private static function theme($folder)
{
extract(Admin::params('bp', 'page', 'blog'));
if ($page->get('delete') == 'theme') {
list($dirs, $files) = Files::iterate($folder, 'recursive');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method theme
has 118 lines of code (exceeds 25 allowed). Consider refactoring. Open
private static function theme($folder)
{
extract(Admin::params('bp', 'page', 'blog'));
if ($page->get('delete') == 'theme') {
list($dirs, $files) = Files::iterate($folder, 'recursive');
Method create
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
private static function create()
{
$html = '';
extract(Admin::params('bp', 'page', 'blog'));
$form = $bp->form('admin_theme_create');
Method page
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function page()
{
extract(Admin::params('page', 'blog', 'bp'));
if ($edit = $page->get('edit')) {
// enforce only one folder path ie. no subfolders
Function create
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
private static function create()
{
$html = '';
extract(Admin::params('bp', 'page', 'blog'));
$form = $bp->form('admin_theme_create');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function page
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public static function page()
{
extract(Admin::params('page', 'blog', 'bp'));
if ($edit = $page->get('edit')) {
// enforce only one folder path ie. no subfolders
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method theme() contains an exit expression. Open
exit;
- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}