collect accesses the super-global variable $_SESSION. Open
public function collect()
{
// return array();
$responseHeaders = $this->response->headers->all();
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
collect accesses the super-global variable $_SESSION. Open
public function collect()
{
// return array();
$responseHeaders = $this->response->headers->all();
- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}
Source
Method collect
has 67 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function collect()
{
// return array();
$responseHeaders = $this->response->headers->all();
Function getCookieHeader
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
private function getCookieHeader($name, $value, $expires, $path, $domain, $secure, $httponly)
{
$cookie = sprintf('%s=%s', $name, urlencode($value));
if (0 !== $expires) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getCookieHeader
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function getCookieHeader($name, $value, $expires, $path, $domain, $secure, $httponly)
{
$cookie = sprintf('%s=%s', $name, urlencode($value));
if (0 !== $expires) {
Function collect
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function collect()
{
// return array();
$responseHeaders = $this->response->headers->all();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getCookieHeader
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
private function getCookieHeader($name, $value, $expires, $path, $domain, $secure, $httponly)