Sign upLogin

Kynetics/uf-android-client

View on GitHub
Star
uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt

Summary

Maintainability
A
0 mins
Test Coverage

Method testMoveSpEntriesDuringInitialization has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Invalid

    @Test
    fun testMoveSpEntriesDuringInitialization(){
        buildSharedPreferences(spPlain, spSecure, secureKeys)
        secureEntries.forEach {
            entry -> entry.putTo(spPlain)
Severity: Minor
Found in uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

        @Test
    fun testUnSecureKeysAreStoredInSharedPreferences() {
        // Context of the app under test.

        val ufSharedPreferences = buildSharedPreferences(spPlain, spSecure, secureKeys)
    Severity: Major
    Found in uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt and 1 other location - About 2 hrs to fix
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 84..96

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 187.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Invalid

        @Test
    fun testSecureKeysAreStoredInEncryptedSharedPreferences() {
        // Context of the app under test.

        val ufSharedPreferences = buildSharedPreferences(spPlain, spSecure, secureKeys)
    Severity: Major
    Found in uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt and 1 other location - About 2 hrs to fix
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 98..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 187.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Invalid

            entries.forEach {
            Assert.assertEquals(it.value, it.retrieveFrom(spSecure))
            Assert.assertFalse(spPlain.contains(it.key))
        }
    Severity: Major
    Found in uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt and 3 other locations - About 1 hr to fix
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 127..130
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 134..137
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 139..142

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Invalid

            secureEntries.forEach {
            Assert.assertEquals(it.value, it.retrieveFrom(spSecure))
            Assert.assertFalse(spPlain.contains(it.key))
        }
    Severity: Major
    Found in uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt and 3 other locations - About 1 hr to fix
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 122..125
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 127..130
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 139..142

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Invalid

            entries.forEach {
            Assert.assertEquals(it.value, it.retrieveFrom(spPlain))
            Assert.assertFalse(spSecure.contains(it.key))
        }
    Severity: Major
    Found in uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt and 3 other locations - About 1 hr to fix
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 122..125
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 127..130
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 134..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Invalid

            secureEntries.forEach {
            Assert.assertEquals(it.value, it.retrieveFrom(spPlain))
            Assert.assertFalse(spSecure.contains(it.key))
        }
    Severity: Major
    Found in uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt and 3 other locations - About 1 hr to fix
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 122..125
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 134..137
    uf-client-service/src/androidTest/java/com/kynetics/uf/android/content/UFSharedPreferencesTest.kt on lines 139..142

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status