Sign upLogin

LAV45/yii2-settings

View on GitHub
Star
src/Settings.php

Summary

Maintainability
A
0 mins
Test Coverage

Remove error control operator '@' on line 101.
Open

    public function decode($value)
    {
        if ($this->serializer === null) {
            return @unserialize($value);
        }
Severity: Minor
Found in src/Settings.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

The method buildKey uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $key = md5(json_encode($key));
            }
Severity: Minor
Found in src/Settings.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class '\yii\di\Instance' in method 'init'.
Open

        $this->storage = Instance::ensure($this->storage, StorageInterface::class);
Severity: Minor
Found in src/Settings.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\yii\helpers\StringHelper' in method 'buildKey'.
Open

                $key = StringHelper::byteLength($key) <= 32 ? $key : md5($key);
Severity: Minor
Found in src/Settings.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

There are no issues that match your filters.

Category
Status