LD4P/sinopia_indexing_pipeline

View on GitHub

Showing 10 of 10 total issues

Function indexMapping has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static get indexMapping() {
    return {
      properties: {
        id: {
          type: "keyword",
Severity: Major
Found in src/TemplateIndexer.js - About 2 hrs to fix

    Function indexMapping has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static get indexMapping() {
        return {
          properties: {
            title: {
              type: "text",
    Severity: Major
    Found in src/ResourceIndexer.js - About 2 hrs to fix

      Function index has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async index(doc) {
          let dataset
          try {
            dataset = await datasetFromJsonld(doc.data)
          } catch (err) {
      Severity: Major
      Found in src/Indexer.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            this.indexObject["type"] = this.dataset
              .match(
                rdf.namedNode(this.doc.uri),
                rdf.namedNode("http://www.w3.org/1999/02/22-rdf-syntax-ns#type")
              )
        Severity: Major
        Found in src/ResourceIndexer.js and 1 other location - About 1 hr to fix
        src/ResourceIndexer.js on lines 64..70

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            return this.dataset
              .match(
                rdf.namedNode(this.doc.uri),
                rdf.namedNode("http://www.w3.org/2000/01/rdf-schema#label")
              )
        Severity: Major
        Found in src/ResourceIndexer.js and 1 other location - About 1 hr to fix
        src/ResourceIndexer.js on lines 102..108

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function delete has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          async delete(mongoId) {
            this.client
              .search({
                index: "_all",
                size: 1,
        Severity: Minor
        Found in src/Indexer.js - About 1 hr to fix

          Function index has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            async index() {
              const resourceId = this.valueFor(
                "http://sinopia.io/vocabulary/hasResourceId"
              )
              // Don't index base templates (i.e., templates for templates).
          Severity: Minor
          Found in src/TemplateIndexer.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                return this.client
                  .index({
                    index: index,
                    type: config.get("indexType"),
                    id: doc.id,
            Severity: Minor
            Found in src/Indexer.js and 1 other location - About 55 mins to fix
            src/Indexer.js on lines 118..127

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    return this.client
                      .delete({
                        index: doc._index,
                        id: doc._id,
                      })
            Severity: Minor
            Found in src/Indexer.js and 1 other location - About 55 mins to fix
            src/Indexer.js on lines 75..86

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                return this.client
                  .index({
                    index: index,
                    type: config.get("indexType"),
                    id: doc.id,
            Severity: Major
            Found in src/Indexer.js - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language