LEMUBIT/PayantAndroid

View on GitHub
app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java

Summary

Maintainability
A
1 hr
Test Coverage

PayantWalletManager has 24 methods (exceeds 20 allowed). Consider refactoring.
Wontfix

public class PayantWalletManager {
    private static PayantApiService payantApiService = new PayantApiClient().getPayantApiService();

    /**
     * Add new wallet using information found in {@code payantWallet}

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

        public static void getWalletTransactions(String walletReferenceCode, PayantHistory payantHistory, final OnGetWalletTransactionsListener onGetWalletTransactionsListener) {
            Call<PayantWalletTransactionsInfo> payantWalletTransactionsInfoCall = payantApiService.getWalletTransactions(Headers.contentType(), Headers.authorization(), walletReferenceCode, payantHistory);
            payantWalletTransactionsInfoCall.enqueue(new Callback<PayantWalletTransactionsInfo>() {
                @Override
                public void onResponse(Call<PayantWalletTransactionsInfo> call, Response<PayantWalletTransactionsInfo> response) {
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 94..113
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 75..92
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 89..106
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 165..182
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 191..208

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

        public static void withdrawFromWallet(String walletReferenceCode, PayantWalletWithdraw payantWalletWithdraw, final OnWithdrawFromWallet onWithdrawFromWallet) {
            Call<PayantWalletWithdrawInfo> payantWalletWithdrawInfoCall = payantApiService.withdrawFromWallet(Headers.contentType(), Headers.authorization(), walletReferenceCode, payantWalletWithdraw);
            payantWalletWithdrawInfoCall.enqueue(new Callback<PayantWalletWithdrawInfo>() {
                @Override
                public void onResponse(Call<PayantWalletWithdrawInfo> call, Response<PayantWalletWithdrawInfo> response) {
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 94..113
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 75..92
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 89..106
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 191..208
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 217..234

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

        public static void changeWalletPassCode(String walletReferenceCode, PassCodes passCodes, final OnChangeWalletPassCodeListener onChangeWalletPassCodeListener) {
            Call<OperationStatus> operationStatusCall = payantApiService.changeWalletPassCode(Headers.contentType(), Headers.authorization(), walletReferenceCode, passCodes);
            operationStatusCall.enqueue(new Callback<OperationStatus>() {
                @Override
                public void onResponse(Call<OperationStatus> call, Response<OperationStatus> response) {
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 94..113
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 75..92
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 165..182
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 191..208
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 217..234

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Invalid

        public static void bulkWithdrawFromWallet(String walletReferenceCode, PayantWalletWithdrawBulk payantWalletWithdrawBulk, final OnBulkWithdrawFromWallet onBulkWithdrawFromWallet) {
            Call<PayantWalletWithdrawBulkInfo> payantWalletWithdrawBulkInfoCall = payantApiService.withdrawFromWalletBulk(Headers.contentType(), Headers.authorization(), walletReferenceCode, payantWalletWithdrawBulk);
            payantWalletWithdrawBulkInfoCall.enqueue(new Callback<PayantWalletWithdrawBulkInfo>() {
                @Override
                public void onResponse(Call<PayantWalletWithdrawBulkInfo> call, Response<PayantWalletWithdrawBulkInfo> response) {
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 94..113
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 75..92
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 89..106
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 165..182
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 217..234

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 94.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Invalid

        public static void getPayantWallet(String walletReferenceCode, final OnGetPayantWalletListener onGetPayantWalletListener) {
            Call<PayantWalletInfo> payantWalletInfoCall = payantApiService.getWallet(Headers.contentType(), Headers.authorization(), walletReferenceCode);
    
            payantWalletInfoCall.enqueue(new Callback<PayantWalletInfo>() {
                @Override
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 32..52
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 62..83
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 122..140
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 33..53
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 63..81
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 90..108
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 116..133
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 141..159
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/payments/PayantPaymentManager.java on lines 28..46
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/payments/PayantPaymentManager.java on lines 54..72
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/payments/PayantPaymentManager.java on lines 81..100
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 27..44
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 50..68
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 117..136
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 35..53
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 139..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Invalid

        public static void toggleWalletEnabledOrDisabled(String walletReferenceCode, final OnWalletToggledListener onWalletToggledListener) {
            Call<OperationStatus> operationStatusCall = payantApiService.disableOrEnableWallet(Headers.contentType(), Headers.authorization(), walletReferenceCode);
            operationStatusCall.enqueue(new Callback<OperationStatus>() {
                @Override
                public void onResponse(Call<OperationStatus> call, Response<OperationStatus> response) {
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 32..52
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 62..83
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 122..140
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 33..53
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 63..81
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 90..108
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 116..133
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 141..159
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/payments/PayantPaymentManager.java on lines 28..46
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/payments/PayantPaymentManager.java on lines 54..72
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/payments/PayantPaymentManager.java on lines 81..100
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 27..44
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 50..68
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 117..136
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 35..53
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 61..80

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Invalid

        public static void addPayantWallet(PayantWallet payantWallet, final OnAddNewPayantWalletListener onAddNewPayantWalletListener) {
            Call<PayantWalletInfo> payantWalletInfoCall = payantApiService.addWallet(Headers.contentType(), Headers.authorization(), payantWallet);
    
            payantWalletInfoCall.enqueue(new Callback<PayantWalletInfo>() {
                @Override
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 32..52
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 62..83
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/clients/PayantClientManager.java on lines 122..140
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 33..53
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 63..81
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 90..108
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 116..133
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/invoices/PayantInvoiceManager.java on lines 141..159
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/payments/PayantPaymentManager.java on lines 28..46
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/payments/PayantPaymentManager.java on lines 54..72
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/payments/PayantPaymentManager.java on lines 81..100
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 27..44
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 50..68
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 117..136
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 61..80
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/wallets/PayantWalletManager.java on lines 139..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 91.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public static void getPayantWalletList(final OnGetPayantWalletsListListener onGetPayantWalletsListListener) {
            Call<PayantWalletInfoList> payantWalletInfoListCall = payantApiService.getWallets(Headers.contentType(), Headers.authorization());
    
            payantWalletInfoListCall.enqueue(new Callback<PayantWalletInfoList>() {
                @Override
    app/src/main/java/com/lemubit/lemuel/androidpayant/operations/product/PayantProductManager.java on lines 97..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 88.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status