LEuLuDyHa/app

View on GitHub

Showing 22 of 85 total issues

Method insert has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
Confirmed

    /**
     * Inserts the given [Edition] in the database.
     *
     * It includes inserting the corresponding [EditionEntity], all its [Cover]s
     * and – if [recursive] – all its authors and works.
Severity: Minor
Found in data/src/main/java/com/github/leuludyha/data/db/LibraryDao.kt - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        while (pCur.moveToNext()) {
                            val phoneNo: String = pCur.getString(
                                pCur.getColumnIndex(
                                    ContactsContract.CommonDataKinds.Phone.NUMBER
                                )
    Severity
    Category
    Status
    Source
    Language