Sign upLogin

LLKennedy/httpgrpc

View on GitHub
Star
httpapi/proxy_grpc.pb.go

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 6 locations. Consider refactoring.
Open

func _ExposedService_ProxyUnary_Handler(srv interface{}, ctx context.Context, dec func(interface{}) error, interceptor grpc.UnaryServerInterceptor) (interface{}, error) {
    in := new(Request)
    if err := dec(in); err != nil {
        return nil, err
    }
Severity: Major
Found in httpapi/proxy_grpc.pb.go and 5 other locations - About 2 hrs to fix
internal/testservice/service/service_grpc.pb.go on lines 220..236
internal/testservice/service/service_grpc.pb.go on lines 238..254
internal/testservice/service/service_grpc.pb.go on lines 256..272
internal/testservice/service/service_grpc.pb.go on lines 563..579
internal/testservice/service/service_grpc.pb.go on lines 581..597

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 221.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

func (c *exposedServiceClient) ProxyStream(ctx context.Context, opts ...grpc.CallOption) (ExposedService_ProxyStreamClient, error) {
    stream, err := c.cc.NewStream(ctx, &_ExposedService_serviceDesc.Streams[0], "/httpapi.ExposedService/ProxyStream", opts...)
    if err != nil {
        return nil, err
    }
Severity: Major
Found in httpapi/proxy_grpc.pb.go and 4 other locations - About 40 mins to fix
internal/testservice/service/service_grpc.pb.go on lines 69..76
internal/testservice/service/service_grpc.pb.go on lines 135..142
internal/testservice/service/service_grpc.pb.go on lines 422..429
internal/testservice/service/service_grpc.pb.go on lines 488..495

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 110.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

func (c *exposedServiceClient) ProxyUnary(ctx context.Context, in *Request, opts ...grpc.CallOption) (*Response, error) {
    out := new(Response)
    err := c.cc.Invoke(ctx, "/httpapi.ExposedService/ProxyUnary", in, out, opts...)
    if err != nil {
        return nil, err
Severity: Major
Found in httpapi/proxy_grpc.pb.go and 5 other locations - About 35 mins to fix
internal/testservice/service/service_grpc.pb.go on lines 42..49
internal/testservice/service/service_grpc.pb.go on lines 51..58
internal/testservice/service/service_grpc.pb.go on lines 60..67
internal/testservice/service/service_grpc.pb.go on lines 404..411
internal/testservice/service/service_grpc.pb.go on lines 413..420

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status