Sign upLogin

LLKennedy/imagetemplate

View on GitHub
Star
components/rectangle/rectangle.go

Summary

Maintainability
A
3 hrs
Test Coverage

Method Component.VerifyAndSetJSONData has 58 lines of code (exceeds 50 allowed). Consider refactoring.
Confirmed

func (component Component) VerifyAndSetJSONData(data interface{}) (render.Component, render.NamedProperties, error) {
    c := component
    props := make(render.NamedProperties)
    stringStruct, ok := data.(*rectangleFormat)
    if !ok {
Severity: Minor
Found in components/rectangle/rectangle.go - About 1 hr to fix

    Method Component.VerifyAndSetJSONData has 10 return statements (exceeds 4 allowed).
    Confirmed

    func (component Component) VerifyAndSetJSONData(data interface{}) (render.Component, render.NamedProperties, error) {
    c := component
    props := make(render.NamedProperties)
    stringStruct, ok := data.(*rectangleFormat)
    if !ok {
    Severity: Major
    Found in components/rectangle/rectangle.go - About 1 hr to fix

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

      func (component Component) SetNamedProperties(properties render.NamedProperties) (render.Component, error) {
    c := component
    var err error
    c.NamedPropertiesMap, err = render.StandardSetNamedProperties(properties, component.NamedPropertiesMap, (&c).delegatedSetProperties)
    if err != nil {
      Severity: Major
      Found in components/rectangle/rectangle.go and 5 other locations - About 40 mins to fix
      components/barcode/barcode.go on lines 82..90
      components/circle/circle.go on lines 60..68
      components/datetime/datetime.go on lines 112..120
      components/image/image.go on lines 69..77
      components/text/text.go on lines 102..110

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status