Sign upLogin

LUXROBO/pymodi

View on GitHub
Star
modi/util/debugging_util.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function run has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def run(self):
        width, height = 930, 790
        window = Tk()
        window.title(f"GUI Debugger for PyMODI (v{modi.__version__})")
        window.geometry(f"{width}x{height}")
Severity: Minor
Found in modi/util/debugging_util.py - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

            if ('recv' not in line and 'send' not in line) or \
            (self.__curr_module and str(self.__curr_module.id) not in line
                and self.__curr_module.module_type != 'network') \
                or (self.__curr_cmd and f'"c":{self.__curr_cmd},' not in line):
            return False
    Severity: Major
    Found in modi/util/debugging_util.py - About 1 hr to fix

      Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def run(self):
        width, height = 930, 790
        window = Tk()
        window.title(f"GUI Debugger for PyMODI (v{modi.__version__})")
        window.geometry(f"{width}x{height}")
      Severity: Minor
      Found in modi/util/debugging_util.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __query_log has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def __query_log(self, line: str) -> bool:
        if ('recv' not in line and 'send' not in line) or \
            (self.__curr_module and str(self.__curr_module.id) not in line
                and self.__curr_module.module_type != 'network') \
                or (self.__curr_cmd and f'"c":{self.__curr_cmd},' not in line):
      Severity: Minor
      Found in modi/util/debugging_util.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status