Showing 26 of 30 total issues
Class VehicleCDMX
has 62 methods (exceeds 20 allowed). Consider refactoring. Open
class VehicleCDMX
# constructor de clase
def initialize (params)
File vehicle_cdmx.rb
has 463 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'httparty'
require 'json'
require 'htmlentities'
class VehicleCDMX
Consider simplifying this complex logical expression. Open
return unless
# verificacion vencida
((user.no_circula_weekday || user.verificacion) && vehicle.verificacion_expired?) ||
# nunca ha verificado
((user.no_circula_weekday || user.verificacion) && !vehicle.verificaciones_approved?) ||
Method modify
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
def modify
@errors = Hash.new
@params = params
begin
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method api
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def api
begin
url = 'http://datos.labplc.mx/movilidad/vehiculos/' + @plate + '.json'
res = HTTParty.get(url)
raise unless res.code == 200
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method results
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def results
@params = params
@session = session.to_hash
@vehicle = VehicleCDMX.new(info_params)
if @vehicle.error
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method weekday
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def weekday (user, vehicle)
return unless
# verificacion vencida
((user.no_circula_weekday || user.verificacion) && vehicle.verificacion_expired?) ||
# nunca ha verificado
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method modify
has 37 lines of code (exceeds 25 allowed). Consider refactoring. Open
def modify
@errors = Hash.new
@params = params
begin
Method new_user
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def new_user
begin
raise unless type_param =~ /\A(EMAIL|PHONE)\z/
@user = User.new(user_params)
rescue
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method new_phone
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def new_phone
begin
@phone = @user.build_phone(phone_params)
rescue
@user.destroy
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method api
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
def api
begin
url = 'http://datos.labplc.mx/movilidad/vehiculos/' + @plate + '.json'
res = HTTParty.get(url)
raise unless res.code == 200
Method results
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
def results
@params = params
@session = session.to_hash
@vehicle = VehicleCDMX.new(info_params)
if @vehicle.error
Method infracciones
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def infracciones
@vehicle = VehicleCDMX.new(plate_param)
if @vehicle.error
redirect_to({ action: 'home' }, { flash: { error: @vehicle.error } })
return
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method new
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def new
@params = params
@errors = Hash.new
return unless new_user
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method verificaciones
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def verificaciones
@vehicle = VehicleCDMX.new(plate_param)
if @vehicle.error
redirect_to({ action: 'home' }, { flash: { error: @vehicle.error } })
return
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method verificaciones
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def verificaciones
return false unless self.verificaciones?
if self.user_vin_valid?
v = @api['verificaciones'].collect { |i|
i if i['vin'].upcase == self.user_vin
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method new_phone
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
def new_phone
begin
@phone = @user.build_phone(phone_params)
rescue
@user.destroy
Consider simplifying this complex logical expression. Open
return unless
# nunca ha verificado
(user.no_circula_weekend && !vehicle.verificaciones_approved?) ||
# no circula holograma uno
(user.no_circula_weekend && vehicle.no_circula_uno? && vehicle.no_circula_weekend?(saturday)) ||
Method icon
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def icon (type)
if type == :ok
'<span class="glyphicon glyphicon-ok-sign green icon"></span>'.html_safe
elsif type == :warning
'<span class="glyphicon glyphicon-info-sign orange icon"></span>'.html_safe
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method new_user_confirm
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def new_user_confirm
if type_param == 'EMAIL'
Notifier.confirm(@user).deliver
elsif type_param == 'PHONE'
@tw_req = { To: @user.phone.number.dup,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"