Sign upLogin

LabPLC/verificalo

View on GitHub
Star

Showing 30 of 30 total issues

Class VehicleCDMX has 62 methods (exceeds 20 allowed). Consider refactoring.
Open

class VehicleCDMX
  
  # constructor de clase
  
  def initialize (params)
Severity: Major
Found in lib/vehicle_cdmx.rb - About 1 day to fix

    File vehicle_cdmx.rb has 463 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'httparty'
require 'json'
require 'htmlentities'

class VehicleCDMX
    Severity: Minor
    Found in lib/vehicle_cdmx.rb - About 7 hrs to fix

      Consider simplifying this complex logical expression.
      Open

          return unless 
      # verificacion vencida
      ((user.no_circula_weekday || user.verificacion) && vehicle.verificacion_expired?) || 
      # nunca ha verificado
      ((user.no_circula_weekday || user.verificacion) && !vehicle.verificaciones_approved?) ||
      Severity: Critical
      Found in app/mailers/notifier.rb - About 3 hrs to fix

        Method modify has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          def modify
    @errors = Hash.new
    @params = params

    begin
        Severity: Minor
        Found in app/controllers/notices_controller.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def verificaciones
    @vehicle = VehicleCDMX.new(plate_param)
    if @vehicle.error
      redirect_to({ action: 'home' }, { flash: { error: @vehicle.error } })
      return
        Severity: Major
        Found in app/controllers/info_controller.rb and 1 other location - About 1 hr to fix
        app/controllers/info_controller.rb on lines 80..101

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method api has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          def api
    begin
      url = 'http://datos.labplc.mx/movilidad/vehiculos/' + @plate + '.json'
      res = HTTParty.get(url)
      raise unless res.code == 200
        Severity: Minor
        Found in lib/vehicle_cdmx.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def infracciones
    @vehicle = VehicleCDMX.new(plate_param)
    if @vehicle.error
      redirect_to({ action: 'home' }, { flash: { error: @vehicle.error } })
      return
        Severity: Major
        Found in app/controllers/info_controller.rb and 1 other location - About 1 hr to fix
        app/controllers/info_controller.rb on lines 56..77

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method results has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          def results
    @params = params
    @session = session.to_hash
    @vehicle = VehicleCDMX.new(info_params)
    if @vehicle.error
        Severity: Minor
        Found in app/controllers/info_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method weekday has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          def weekday (user, vehicle) 
    return unless 
      # verificacion vencida
      ((user.no_circula_weekday || user.verificacion) && vehicle.verificacion_expired?) || 
      # nunca ha verificado
        Severity: Minor
        Found in app/mailers/notifier.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method modify has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def modify
    @errors = Hash.new
    @params = params

    begin
        Severity: Minor
        Found in app/controllers/notices_controller.rb - About 1 hr to fix

          Method new_user has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            def new_user
    begin
      raise unless type_param =~ /\A(EMAIL|PHONE)\z/
      @user = User.new(user_params)
    rescue
          Severity: Minor
          Found in app/controllers/notices_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method new_phone has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            def new_phone
    begin
      @phone = @user.build_phone(phone_params)
    rescue
      @user.destroy
          Severity: Minor
          Found in app/controllers/notices_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method api has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def api
    begin
      url = 'http://datos.labplc.mx/movilidad/vehiculos/' + @plate + '.json'
      res = HTTParty.get(url)
      raise unless res.code == 200
          Severity: Minor
          Found in lib/vehicle_cdmx.rb - About 1 hr to fix

            Method results has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def results
    @params = params
    @session = session.to_hash
    @vehicle = VehicleCDMX.new(info_params)
    if @vehicle.error
            Severity: Minor
            Found in app/controllers/info_controller.rb - About 1 hr to fix

              Method infracciones has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def infracciones
    @vehicle = VehicleCDMX.new(plate_param)
    if @vehicle.error
      redirect_to({ action: 'home' }, { flash: { error: @vehicle.error } })
      return
              Severity: Minor
              Found in app/controllers/info_controller.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method new has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def new
    @params = params
    @errors = Hash.new

    return unless new_user
              Severity: Minor
              Found in app/controllers/notices_controller.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method verificaciones has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def verificaciones
    @vehicle = VehicleCDMX.new(plate_param)
    if @vehicle.error
      redirect_to({ action: 'home' }, { flash: { error: @vehicle.error } })
      return
              Severity: Minor
              Found in app/controllers/info_controller.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method verificaciones has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def verificaciones
    return false unless self.verificaciones?
    if self.user_vin_valid?
      v = @api['verificaciones'].collect { |i| 
        i if i['vin'].upcase == self.user_vin
              Severity: Minor
              Found in lib/vehicle_cdmx.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method new_phone has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def new_phone
    begin
      @phone = @user.build_phone(phone_params)
    rescue
      @user.destroy
              Severity: Minor
              Found in app/controllers/notices_controller.rb - About 1 hr to fix

                Consider simplifying this complex logical expression.
                Open

                    return unless 
      # nunca ha verificado
      (user.no_circula_weekend && !vehicle.verificaciones_approved?) ||
      # no circula holograma uno
      (user.no_circula_weekend && vehicle.no_circula_uno? && vehicle.no_circula_weekend?(saturday)) ||
                Severity: Major
                Found in app/mailers/notifier.rb - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language