Sign upLogin

LafayetteCollegeLibraries/spot

View on GitHub
Star
app/indexers/concerns/indexes_citation_metadata.rb

Summary

Maintainability
A
55 mins
Test Coverage
A
100%

Method generate_solr_document has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Confirmed

  def generate_solr_document
    super.tap do |doc|
      # bibliographic_citation is a part of Spot::CoreMetadata, which is included on all works,
      # but this should safeguard in the event that's not the case in the future
      next doc unless object.respond_to?(:bibliographic_citation) && object.bibliographic_citation.present?
Severity: Minor
Found in app/indexers/concerns/indexes_citation_metadata.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status