Sign upLogin

Lambda-School-Labs/Merch-Dropper-fe

View on GitHub
Star

Showing 24 of 24 total issues

Function AddProductToTable has 198 lines of code (exceeds 50 allowed). Consider refactoring.
Open

const AddProductToTable = (props, history) => {
  const classes = useStyles();
  const [stores, setStores] = useState("");
  const data = scalableData(props.garment);
  const [product, setProduct] = useState({
Severity: Major
Found in merch-dropper/src/components/Shirt/AddProductToTable.js - About 6 hrs to fix

    Function NavBar has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

    const NavBar = ({ hidden, history, location }) => {
  const classes = useStyles();
  const dispatch = useDispatch();
  const { loginWithRedirect, logout } = useAuth0();
  const { pathname } = location;
    Severity: Minor
    Found in merch-dropper/src/components/NavBar.js - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File LearnMore.js has 325 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React from 'react';
import styled from 'styled-components';
import BoardRoom from '../images/BoardRoom.jpg';
import OurTeam from '../images/OurTeam.jpg';
    Severity: Minor
    Found in merch-dropper/src/components/LearnMore.js - About 3 hrs to fix

      File Styled.js has 279 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import styled from "styled-components";

export const MainContainer = styled.div`
  background: #e5e5e5;
  height: 1024px;
      Severity: Minor
      Found in merch-dropper/src/components/Onboarding/Styled.js - About 2 hrs to fix

        Function DevAuth has 90 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        const DevAuth = () => {
    const history = useHistory()
    const [credentials, setCredentials] = useState({
        email: '',
        password: ''
        Severity: Major
        Found in merch-dropper/src/components/Auth/DevAuth.js - About 2 hrs to fix

          File NavBar.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          import React, { useState, useEffect } from "react";
import { connect, useDispatch } from "react-redux";
import { withRouter, Link } from "react-router-dom";
import { axiosWithAuth } from "../utils/axiosWithAuth";
// components
          Severity: Minor
          Found in merch-dropper/src/components/NavBar.js - About 2 hrs to fix

            Function Nav has 83 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

              const Nav = () => {
    if (!!localStorage.getItem("profile")) {
      return (
        <nav className={classes.ButtonWrapper}>
          {window.location.pathname === `/${store_name}` ? (
            Severity: Major
            Found in merch-dropper/src/components/NavBar.js - About 2 hrs to fix

              Function Settings has 83 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              const Settings = () => {
  let connectStripeURL;
  if (process.env.REACT_APP_BASE_URL === "development") {
    connectStripeURL = "http://localhost:3000/stripe-setup";
  } else {
              Severity: Major
              Found in merch-dropper/src/components/Dashboard/Settings.js - About 2 hrs to fix

                Function ProductReducer has 78 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                 const ProductReducer = (state = initialState, action) =>{
    switch (action.type) {
        case GET_PRODUCTS_START:
            return { 
                ...state,
                Severity: Major
                Found in merch-dropper/src/store/reducers/ProductReducers.js - About 2 hrs to fix

                  Function FAQ has 77 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                  const FAQ = () =>{
  const classes = useStyles();

  return (
    <div className={classes.root}>
                  Severity: Major
                  Found in merch-dropper/src/components/FAQ.js - About 2 hrs to fix

                    Function ShippingAddress has 72 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                    const ShippingAddress = () => {
    const dispatch = useDispatch();
    const history = useHistory();
    const classes = useStyles();
    const [address, setAddress] = useState(initialQuoteState.sendQuote.spInfo.address)
                    Severity: Major
                    Found in merch-dropper/src/components/Cart/ShippingAddress.js - About 1 hr to fix

                      Function LearnMore has 69 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      const LearnMore = () => {

    return (
        <PageWrapper>
            <TopImage>
                      Severity: Major
                      Found in merch-dropper/src/components/LearnMore.js - About 1 hr to fix

                        Function StripeConnect has 66 lines of code (exceeds 50 allowed). Consider refactoring.
                        Open

                        const StripeConnect = () => {
  const [queryString, setQueryString] = useState(window.location.search);
  let stripeConnected = false;
  let stripeError = false;
  const [activeStep, setActiveStep] = useState(1);
                        Severity: Major
                        Found in merch-dropper/src/components/Onboarding/StripeConnect.js - About 1 hr to fix

                          Function QuoteReducer has 65 lines of code (exceeds 50 allowed). Consider refactoring.
                          Open

                          export const QuoteReducer = (state = initialQuoteState, action) => {
    switch(action.type){
        case GET_QUOTE_START:
            return{
                ...state,
                          Severity: Major
                          Found in merch-dropper/src/store/reducers/QuoteReducer.js - About 1 hr to fix

                            Function App has 58 lines of code (exceeds 50 allowed). Consider refactoring.
                            Open

                            function App() {
  const [design, setDesign] = useState(initialShirtState.designInfo);
  const [garment, setGarment] = useState(initialShirtState.garment);
  const [product, setProduct] = useState(initialState.products)
  const [thumbRender, setThumbRender] = useState();
                            Severity: Major
                            Found in merch-dropper/src/App.js - About 1 hr to fix

                              Function CheckoutPage has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                              Open

                              const CheckoutPage = ({
  cart,
  total,
  match,
  addItem,
                              Severity: Minor
                              Found in merch-dropper/src/components/Cart/Checkout.js - About 1 hr to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    price: null
                              Severity: Major
                              Found in merch-dropper/src/store/reducers/initialState.js and 1 other location - About 1 hr to fix
                              merch-dropper/src/store/reducers/initialState.js on lines 4..17

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 55.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                products: 
    {
      id: "",
      productName: "",
      color: "",
                              Severity: Major
                              Found in merch-dropper/src/store/reducers/initialState.js and 1 other location - About 1 hr to fix
                              merch-dropper/src/store/reducers/initialState.js on lines 16..16

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 55.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Function parseURLParams has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                              export default function parseURLParams(url) {
    var queryStart = url.indexOf("?") + 1,
        queryEnd   = url.indexOf("#") + 1 || url.length + 1,
        query = url.slice(queryStart, queryEnd - 1),
        pairs = query.replace(/\+/g, " ").split("&"),
                              Severity: Minor
                              Found in merch-dropper/src/components/Shirt/parseURL.js - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Function Settings has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                              Open

                              const Settings = () => {
  let connectStripeURL;
  if (process.env.REACT_APP_BASE_URL === "development") {
    connectStripeURL = "http://localhost:3000/stripe-setup";
  } else {
                              Severity: Minor
                              Found in merch-dropper/src/components/Dashboard/Settings.js - About 45 mins to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              Severity
                              Category
                              Status
                              Source
                              Language