Sign upLogin

Lambda-School-Labs/allay-ds

View on GitHub
Star
allay-ds-api/fastapi_app/text_preprocessing.py

Summary

Maintainability
A
2 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

            if (
                not token.is_stop  # spaCy stopwords
                and not token.is_punct  # punctuation
                and token.pos_ != 'PRON'  # pronouns
                and len(token.lemma_) > 2  # two or less characters
Severity: Critical
Found in allay-ds-api/fastapi_app/text_preprocessing.py - About 2 hrs to fix

    Function make_lemmas has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def make_lemmas(nlp, docs):
    """Creates a list of documents containing the lemmas of each document
    in the input docs.

    :param nlp: spaCy NLP model to use
    Severity: Minor
    Found in allay-ds-api/fastapi_app/text_preprocessing.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status