Sign upLogin

Lambda-School-Labs/community-calendar-ios

View on GitHub
Star
Community Calendar/Pods/OktaOidc/Okta/OktaOidc/Internal/Tasks/OktaOidcBrowserTask.swift

Summary

Maintainability
B
4 hrs
Test Coverage

Function signIn has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func signIn(callback: @escaping ((OIDAuthState?, OktaOidcError?) -> Void)) {
        self.downloadOidcConfiguration() { oidConfig, error in
            guard let oidConfiguration = oidConfig else {
                callback(nil, error)
                return
Severity: Minor
Found in Community Calendar/Pods/OktaOidc/Okta/OktaOidc/Internal/Tasks/OktaOidcBrowserTask.swift - About 1 hr to fix

    Function signOutWithIdToken has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        func signOutWithIdToken(idToken: String,
                            callback: @escaping (Void?, OktaOidcError?) -> Void) {
        self.downloadOidcConfiguration() { oidConfig, error in
            guard let oidConfig = oidConfig else {
                callback(nil, error)
    Severity: Minor
    Found in Community Calendar/Pods/OktaOidc/Okta/OktaOidc/Internal/Tasks/OktaOidcBrowserTask.swift - About 1 hr to fix

      Function signIn has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          func signIn(callback: @escaping ((OIDAuthState?, OktaOidcError?) -> Void)) {
        self.downloadOidcConfiguration() { oidConfig, error in
            guard let oidConfiguration = oidConfig else {
                callback(nil, error)
                return
      Severity: Minor
      Found in Community Calendar/Pods/OktaOidc/Okta/OktaOidc/Internal/Tasks/OktaOidcBrowserTask.swift - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function signOutWithIdToken has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          func signOutWithIdToken(idToken: String,
                            callback: @escaping (Void?, OktaOidcError?) -> Void) {
        self.downloadOidcConfiguration() { oidConfig, error in
            guard let oidConfig = oidConfig else {
                callback(nil, error)
      Severity: Minor
      Found in Community Calendar/Pods/OktaOidc/Okta/OktaOidc/Internal/Tasks/OktaOidcBrowserTask.swift - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status