Sign upLogin

Lambda-School-Labs/kansha-fe

View on GitHub
Star
src/components/Feed/ReactionButton.jsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function ReactionButton has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

export const ReactionButton = ({ reactions, rec_id, id, open, inModal }) => {
    const dispatch = useDispatch();

    // checks whether the current logged in user is among those who liekd the post
    const userReaction = useMemo(() => {
Severity: Minor
Found in src/components/Feed/ReactionButton.jsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    const userReaction = useMemo(() => {
        if (reactions) {
            return reactions.reduce(
                (a, reaction) => (id === reaction.user_id ? reaction.id : a),
                0,
Severity: Major
Found in src/components/Feed/ReactionButton.jsx and 1 other location - About 1 hr to fix
src/components/Feed/CommentButton.jsx on lines 11..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        <button
            className={`${open ? `reaction-button` : `hidden-rec`}`}
            aria-label={
                userReaction ? 'remove reaction to post' : 'react to post'
            }
Severity: Minor
Found in src/components/Feed/ReactionButton.jsx and 1 other location - About 40 mins to fix
src/components/Feed/CommentButton.jsx on lines 23..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status