Lambda-School-Labs/nutrition-tracker-ios-pt7

View on GitHub
Nutrivurv/Nutrivurv/BarcodeSearchViewController.swift

Summary

Maintainability
C
1 day
Test Coverage

File BarcodeSearchViewController.swift has 270 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import AVFoundation
import UIKit
import SwiftUI

class BarcodeSearchViewController: UIViewController, AVCapturePhotoCaptureDelegate {
Severity: Minor
Found in Nutrivurv/Nutrivurv/BarcodeSearchViewController.swift - About 2 hrs to fix

    Function searchForFoodByUPC has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        func searchForFoodByUPC(_ upc: String) {
            self.searchController?.searchForFoodItemWithUPC(searchTerm: upc) { (error) in
                DispatchQueue.main.asyncAfter(deadline: .now() + 0.5) {
                    self.hideLoadingIndicators()
                    
    Severity: Minor
    Found in Nutrivurv/Nutrivurv/BarcodeSearchViewController.swift - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function setUpCameraLiveView has 57 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

        private func setUpCameraLiveView() {
            // Ensure we have appropriate permissions before a capture session is established
            guard permissionGranted != false else {
                return
            }
    Severity: Major
    Found in Nutrivurv/Nutrivurv/BarcodeSearchViewController.swift - About 1 hr to fix

      Function setUpCameraLiveView has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          private func setUpCameraLiveView() {
              // Ensure we have appropriate permissions before a capture session is established
              guard permissionGranted != false else {
                  return
              }
      Severity: Minor
      Found in Nutrivurv/Nutrivurv/BarcodeSearchViewController.swift - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function checkPermissions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private func checkPermissions() {
              let mediaType = AVMediaType.video
              let status = AVCaptureDevice.authorizationStatus(for: mediaType)
              
              switch status {
      Severity: Minor
      Found in Nutrivurv/Nutrivurv/BarcodeSearchViewController.swift - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function metadataOutput has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          func metadataOutput(_ output: AVCaptureMetadataOutput, didOutput metadataObjects: [AVMetadataObject], from connection: AVCaptureConnection) {
              
              // Stop capture session to prevent multiple network calls prior to completion
              captureSession.stopRunning()
              
      Severity: Minor
      Found in Nutrivurv/Nutrivurv/BarcodeSearchViewController.swift - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                  return
      Severity: Major
      Found in Nutrivurv/Nutrivurv/BarcodeSearchViewController.swift - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return
        Severity: Major
        Found in Nutrivurv/Nutrivurv/BarcodeSearchViewController.swift - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status