Sign upLogin

Lambda-School-Labs/nutrition-tracker-ios-pt7

View on GitHub
Star
Nutrivurv/Nutrivurv/UserController.swift

Summary

Maintainability
C
1 day
Test Coverage

Function registerUser has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    func registerUser(user: UserProfile, completion: @escaping (Result<Bool, NetworkError>) -> Void) {
        let registerURL = baseURL.appendingPathComponent("ios/register")
        var request = URLRequest(url: registerURL)
        
        request.addValue("application/json", forHTTPHeaderField: "Content-Type")
Severity: Minor
Found in Nutrivurv/Nutrivurv/UserController.swift - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function registerUser has 85 lines of code (exceeds 50 allowed). Consider refactoring.
Open

    func registerUser(user: UserProfile, completion: @escaping (Result<Bool, NetworkError>) -> Void) {
        let registerURL = baseURL.appendingPathComponent("ios/register")
        var request = URLRequest(url: registerURL)
        
        request.addValue("application/json", forHTTPHeaderField: "Content-Type")
Severity: Major
Found in Nutrivurv/Nutrivurv/UserController.swift - About 2 hrs to fix

    Function loginUser has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        func loginUser(user: UserAuth, completion: @escaping (Result<Bool, NetworkError>) -> Void) {
        let loginURL = baseURL.appendingPathComponent("login")
        var request = URLRequest(url: loginURL)
        
        request.addValue("application/json", forHTTPHeaderField: "Content-Type")
    Severity: Minor
    Found in Nutrivurv/Nutrivurv/UserController.swift - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function loginUser has 62 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

        func loginUser(user: UserAuth, completion: @escaping (Result<Bool, NetworkError>) -> Void) {
        let loginURL = baseURL.appendingPathComponent("login")
        var request = URLRequest(url: loginURL)
        
        request.addValue("application/json", forHTTPHeaderField: "Content-Type")
    Severity: Major
    Found in Nutrivurv/Nutrivurv/UserController.swift - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                      return
      Severity: Major
      Found in Nutrivurv/Nutrivurv/UserController.swift - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return
        Severity: Major
        Found in Nutrivurv/Nutrivurv/UserController.swift - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return
          Severity: Major
          Found in Nutrivurv/Nutrivurv/UserController.swift - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return
            Severity: Major
            Found in Nutrivurv/Nutrivurv/UserController.swift - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return
              Severity: Major
              Found in Nutrivurv/Nutrivurv/UserController.swift - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return
                Severity: Major
                Found in Nutrivurv/Nutrivurv/UserController.swift - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return
                  Severity: Major
                  Found in Nutrivurv/Nutrivurv/UserController.swift - About 30 mins to fix

                    There are no issues that match your filters.

                    Category
                    Status