Issues - Lambda-School-Labs/nutrition-tracker-ios-pt7

Identical blocks of code found in 4 locations. Consider refactoring.
Open

        guard let token = getUserToken() else {
            print("No token found for user")
            DispatchQueue.main.async {
                completion(.failure(.noAuth))
            }

Found in Nutrivurv/Nutrivurv/FoodLogController.swift and 3 other locations - About 35 mins to fix

Read up
Read up

Nutrivurv/Nutrivurv/FoodLogController.swift on lines 181..187

Nutrivurv/Nutrivurv/FoodLogController.swift on lines 240..246

Nutrivurv/Nutrivurv/FoodLogController.swift on lines 380..386

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Lambda-School-Labs/nutrition-tracker-ios-pt7

Showing 113 of 122 total issues

Identical blocks of code found in 4 locations. Consider refactoring.
Open

Duplicated Code

Tuning

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Duplicated Code

Tuning

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Duplicated Code

Tuning

Refactorings

Further Reading

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Severity

Category

Status

Source

Language

Lambda-School-Labs/nutrition-tracker-ios-pt7

Showing 113 of 122 total issues

Identical blocks of code found in 4 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring. Open

Duplicated Code

Tuning

Refactorings

Further Reading

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Avoid too many return statements within this function. Open

Severity

Category

Status

Source

Language

Identical blocks of code found in 4 locations. Consider refactoring.
Open

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open

Avoid too many `return` statements within this function.
Open