Sign upLogin

Laravelium/laravel-sitemap

View on GitHub
Star

Showing 14 of 14 total issues

Function addItem has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.
Open

    public function addItem($params = [])
    {

        // if is multidimensional
        if (array_key_exists(1, $params)) {
Severity: Minor
Found in src/Laravelium/Sitemap/Sitemap.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function store has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    public function store($format = 'xml', $filename = 'sitemap', $path = null, $style = null)
    {
        // turn off caching for this method
        $this->model->setUseCache(false);
Severity: Minor
Found in src/Laravelium/Sitemap/Sitemap.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addItem has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function addItem($params = [])
    {

        // if is multidimensional
        if (array_key_exists(1, $params)) {
Severity: Major
Found in src/Laravelium/Sitemap/Sitemap.php - About 3 hrs to fix

    Model has 30 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Model
{
    /**
     * @var bool
     */
    Severity: Minor
    Found in src/Laravelium/Sitemap/Model.php - About 3 hrs to fix

      File Sitemap.php has 281 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

namespace Laravelium\Sitemap;

/**
      Severity: Minor
      Found in src/Laravelium/Sitemap/Sitemap.php - About 2 hrs to fix

        Method store has 55 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function store($format = 'xml', $filename = 'sitemap', $path = null, $style = null)
    {
        // turn off caching for this method
        $this->model->setUseCache(false);
        Severity: Major
        Found in src/Laravelium/Sitemap/Sitemap.php - About 2 hrs to fix

          Method generate has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function generate($format = 'xml', $style = null)
    {
        // check if caching is enabled, there is a cached content and its duration isn't expired
        if ($this->isCached()) {
            ('sitemapindex' == $format) ? $this->model->resetSitemaps($this->cache->get($this->model->getCacheKey())) : $this->model->resetItems($this->cache->get($this->model->getCacheKey()));
          Severity: Minor
          Found in src/Laravelium/Sitemap/Sitemap.php - About 1 hr to fix

            Method add has 10 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function add($loc, $lastmod = null, $priority = null, $freq = null, $images = [], $title = null, $translations = [], $videos = [], $googlenews = [], $alternates = [])
            Severity: Major
            Found in src/Laravelium/Sitemap/Sitemap.php - About 1 hr to fix

              Function generate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function generate($format = 'xml', $style = null)
    {
        // check if caching is enabled, there is a cached content and its duration isn't expired
        if ($this->isCached()) {
            ('sitemapindex' == $format) ? $this->model->resetSitemaps($this->cache->get($this->model->getCacheKey())) : $this->model->resetItems($this->cache->get($this->model->getCacheKey()));
              Severity: Minor
              Found in src/Laravelium/Sitemap/Sitemap.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              <?= '<'.'?'.'xml version="1.0" encoding="UTF-8"?>'."\n"; ?>
<rss version="2.0" xmlns:ror="http://rorweb.com/0.1/" >
<channel>
    <title><?= $channel['title'] ?></title>
    <link><?= $channel['link'] ?></link>
              Severity: Minor
              Found in src/views/ror-rss.php and 1 other location - About 55 mins to fix
              src/views/ror-rdf.php on lines 1..18

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 98.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              <?= '<'.'?'.'xml version="1.0" encoding="UTF-8"?>'."\n"; ?>
<rdf:RDF xmlns="http://rorweb.com/0.1/" xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#">
<Resource rdf:about="sitemap">
    <title><?= $channel['title'] ?></title>
    <url><?= $channel['link'] ?></url>
              Severity: Minor
              Found in src/views/ror-rdf.php and 1 other location - About 55 mins to fix
              src/views/ror-rss.php on lines 1..17

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 98.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function __construct(array $config, CacheRepository $cache, ConfigRepository $configRepository, Filesystem $file, ResponseFactory $response, ViewFactory $view)
              Severity: Minor
              Found in src/Laravelium/Sitemap/Sitemap.php - About 45 mins to fix

                Avoid too many return statements within this method.
                Open

                                return ['content' => $this->view->make('sitemap::'.$format, ['items' => $this->model->getItems(), 'style' => $style])->render(), 'headers' => ['Content-type' => 'text/xml; charset=utf-8']];
                Severity: Major
                Found in src/Laravelium/Sitemap/Sitemap.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return ['content' => $this->view->make('sitemap::sitemapindex', ['sitemaps' => $this->model->getSitemaps(), 'style' => $style])->render(), 'headers' => ['Content-type' => 'text/xml; charset=utf-8']];
                  Severity: Major
                  Found in src/Laravelium/Sitemap/Sitemap.php - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language