Showing 12 of 14 total issues
Function addItem
has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring. Open
public function addItem($params = [])
{
// if is multidimensional
if (array_key_exists(1, $params)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function store
has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring. Open
public function store($format = 'xml', $filename = 'sitemap', $path = null, $style = null)
{
// turn off caching for this method
$this->model->setUseCache(false);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method addItem
has 96 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function addItem($params = [])
{
// if is multidimensional
if (array_key_exists(1, $params)) {
Model
has 30 functions (exceeds 20 allowed). Consider refactoring. Open
class Model
{
/**
* @var bool
*/
File Sitemap.php
has 281 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace Laravelium\Sitemap;
/**
Method store
has 55 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function store($format = 'xml', $filename = 'sitemap', $path = null, $style = null)
{
// turn off caching for this method
$this->model->setUseCache(false);
Method generate
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function generate($format = 'xml', $style = null)
{
// check if caching is enabled, there is a cached content and its duration isn't expired
if ($this->isCached()) {
('sitemapindex' == $format) ? $this->model->resetSitemaps($this->cache->get($this->model->getCacheKey())) : $this->model->resetItems($this->cache->get($this->model->getCacheKey()));
Function generate
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
public function generate($format = 'xml', $style = null)
{
// check if caching is enabled, there is a cached content and its duration isn't expired
if ($this->isCached()) {
('sitemapindex' == $format) ? $this->model->resetSitemaps($this->cache->get($this->model->getCacheKey())) : $this->model->resetItems($this->cache->get($this->model->getCacheKey()));
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add
has 10 arguments (exceeds 4 allowed). Consider refactoring. Open
public function add($loc, $lastmod = null, $priority = null, $freq = null, $images = [], $title = null, $translations = [], $videos = [], $googlenews = [], $alternates = [])
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function __construct(array $config, CacheRepository $cache, ConfigRepository $configRepository, Filesystem $file, ResponseFactory $response, ViewFactory $view)
Avoid too many return
statements within this method. Open
return ['content' => $this->view->make('sitemap::'.$format, ['items' => $this->model->getItems(), 'style' => $style])->render(), 'headers' => ['Content-type' => 'text/xml; charset=utf-8']];
Avoid too many return
statements within this method. Open
return ['content' => $this->view->make('sitemap::sitemapindex', ['sitemaps' => $this->model->getSitemaps(), 'style' => $style])->render(), 'headers' => ['Content-type' => 'text/xml; charset=utf-8']];