Sign upLogin

LarryHsiao/Nyx

View on GitHub
Star
app/src/main/java/com/larryhsiao/nyx/LocalFileSync.java

Summary

Maintainability
A
1 hr
Test Coverage

Method compressImageToInternal has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void compressImageToInternal(
        File internalRoot,
        Attachment attachment,
        String ext
    ) throws IOException {
Severity: Minor
Found in app/src/main/java/com/larryhsiao/nyx/LocalFileSync.java - About 1 hr to fix

    <p> tag should be preceded with an empty line.</p>
    Open

     * <p>
    Severity: Minor
    Found in app/src/main/java/com/larryhsiao/nyx/LocalFileSync.java by checkstyle

    Checks the Javadoc paragraph.

    Checks that:

    • There is one blank line between each of two paragraphs.
    • Each paragraph but the first has <p> immediately before the first word, withno space after.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Line is longer than 100 characters (found 109).
    Open

                if ("jpg".equalsIgnoreCase(ext) || "jpeg".equalsIgnoreCase(ext) || "png".equalsIgnoreCase(ext)) {
    Severity: Minor
    Found in app/src/main/java/com/larryhsiao/nyx/LocalFileSync.java by checkstyle

    Checks for long lines.

    Rationale: Long lines are hard to read in printouts or if developershave limited screen space for the source code, e.g. if the IDEdisplays additional information like project tree, class hierarchy,etc.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    Using the '.*' form of import should be avoided - com.larryhsiao.nyx.core.attachments.*.
    Open

    import com.larryhsiao.nyx.core.attachments.*;
    Severity: Minor
    Found in app/src/main/java/com/larryhsiao/nyx/LocalFileSync.java by checkstyle

    Checks that there are no import statements that use the * notation.

    Rationale: Importing all classes from a package or staticmembers from a class leads to tight coupling between packagesor classes and might lead to problems when a new version of alibrary introduces name clashes.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    All overloaded methods should be placed next to each other. Placing non-overloaded methods in between overloaded methods with the same type is a violation. Previous overloaded method located at line '66'.
    Open

        private void copyToInternal(String ext, File internalRoot, Attachment attachment)
    Severity: Minor
    Found in app/src/main/java/com/larryhsiao/nyx/LocalFileSync.java by checkstyle

    Checks that overloaded methods are grouped together. Overloaded methods have the samename but different signatures where the signature can differ by the number of inputparameters or type of input parameters or both.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    <p> tag should be placed immediately before the first word, with no space after.</p>
    Open

     * <p>
    Severity: Minor
    Found in app/src/main/java/com/larryhsiao/nyx/LocalFileSync.java by checkstyle

    Checks the Javadoc paragraph.

    Checks that:

    • There is one blank line between each of two paragraphs.
    • Each paragraph but the first has <p> immediately before the first word, withno space after.

    This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

    There are no issues that match your filters.

    Category
    Status