Sign upLogin

LasLabs/python-cannabis-reports

View on GitHub
Star
cannabis_reports/apis/abstract_item_endpoint.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function get_available has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def get_available(cls, session, ucpc, lat, lng, radius=10, limit=None):
Severity: Minor
Found in cannabis_reports/apis/abstract_item_endpoint.py - About 45 mins to fix

    Function search has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def search(cls, session, query, sort='created_at', path='type',
    Severity: Minor
    Found in cannabis_reports/apis/abstract_item_endpoint.py - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @classmethod
    def get_reviews(cls, session, ucpc, limit=None):
        """Get the reviews for a cannabis object.

        Args:
      Severity: Major
      Found in cannabis_reports/apis/abstract_item_endpoint.py and 1 other location - About 1 hr to fix
      cannabis_reports/apis/dispensaries.py on lines 20..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 44.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          @classmethod
    def get_user(cls, session, ucpc):
        """Get the user who added the object to the database.

        Args:
      Severity: Major
      Found in cannabis_reports/apis/abstract_item_endpoint.py and 3 other locations - About 1 hr to fix
      cannabis_reports/apis/abstract_item_endpoint.py on lines 64..80
      cannabis_reports/apis/abstract_product_endpoint.py on lines 17..32
      cannabis_reports/apis/abstract_product_endpoint.py on lines 38..53

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          @classmethod
    def get_effects_flavors(cls, session, ucpc):
        """Get the average effects and flavors from reviews for this object.

        Args:
      Severity: Major
      Found in cannabis_reports/apis/abstract_item_endpoint.py and 3 other locations - About 1 hr to fix
      cannabis_reports/apis/abstract_item_endpoint.py on lines 21..36
      cannabis_reports/apis/abstract_product_endpoint.py on lines 17..32
      cannabis_reports/apis/abstract_product_endpoint.py on lines 38..53

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 41.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status