Sign upLogin

Leadtech/BootFramework

View on GitHub
Star
src/Leadtech/Boot/Http/Router/RouteMatch.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function __construct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct(array $routeMatch)
    {
        // Get the route params + route match properties
        foreach ($routeMatch as $key => $value) {
            if ($this->isClassMember($key)) {
Severity: Minor
Found in src/Leadtech/Boot/Http/Router/RouteMatch.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function verifyClient has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function verifyClient(Request $request)
    {
        // Declare vars
        $clientIp = $request->getClientIp();
        $host = $request->getHost();
Severity: Minor
Found in src/Leadtech/Boot/Http/Router/RouteMatch.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Consider simplifying this complex logical expression.
Open

        if ($this->isPublicIpRangesDenied() && NetworkUtils::isPublicIpRange($clientIp)
            || $this->isPrivateIpRangesDenied() && NetworkUtils::isPrivateIpRange($clientIp)
            || $this->isReservedIpRangesDenied() && NetworkUtils::isReservedIpRange($clientIp)) {
            // Access denied!
            $accessGranted = false;
Severity: Major
Found in src/Leadtech/Boot/Http/Router/RouteMatch.php - About 40 mins to fix

    There are no issues that match your filters.

    Category
    Status