File FeaturesEditor.java
has 455 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*
* Copyright (c) 1998-2005, The University of Sheffield.
*
* This file is part of GATE (see http://gate.ac.uk/), and is free software,
* licenced under the GNU Library General Public License, Version 2, June 1991
Method prepareCombo
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
protected void prepareCombo(JComboBox combo, int row, int column) {
Feature feature = (Feature)featureList.get(row);
DefaultComboBoxModel comboModel = (DefaultComboBoxModel)combo.getModel();
comboModel.removeAllElements();
switch(column){
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
FeatureEditorRenderer
has 21 methods (exceeds 20 allowed). Consider refactoring. Open
protected class FeatureEditorRenderer extends DefaultCellEditor implements
TableCellRenderer {
public FeatureEditorRenderer() {
super(new JComboBox());
defaultComparator = new ObjectComparator();
Method actionPerformed
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
public void actionPerformed(ActionEvent ae) {
int row = mainTable.getEditingRow();
if(row < 0) return;
Feature feature = (Feature)featureList.get(row);
if(feature == emptyFeature) {
Method prepareCombo
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected void prepareCombo(JComboBox combo, int row, int column) {
Feature feature = (Feature)featureList.get(row);
DefaultComboBoxModel comboModel = (DefaultComboBoxModel)combo.getModel();
comboModel.removeAllElements();
switch(column){
Method initGUI
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected void initGUI() {
featuresModel = new FeaturesTableModel();
mainTable = new XJTable();
mainTable.setModel(featuresModel);
mainTable.setTableHeader(null);
Method populate
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected void populate() {
featureList.clear();
// get all the existing features
Set features = new HashSet();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method setValueAt
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public void setValueAt(Object aValue, int rowIndex, int columnIndex) {
Feature feature = (Feature)featureList.get(rowIndex);
if(targetFeatures == null) {
targetFeatures = Factory.newFeatureMap();
populate();
Method getTableCellRendererComponent
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public Component getTableCellRendererComponent(JTable table, Object value,
boolean isSelected, boolean hasFocus, int row, int column) {
Feature feature = (Feature)featureList.get(row);
switch(column){
case ICON_COL:
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getTableCellRendererComponent
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public Component getTableCellRendererComponent(JTable table, Object value,
boolean isSelected, boolean hasFocus, int row, int column) {
Method repaint
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public void repaint(long tm, int x, int y, int width, int height) {
Method getTableCellEditorComponent
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public Component getTableCellEditorComponent(JTable table, Object value,
boolean isSelected, int row, int column) {
Method repaint
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public void repaint(long tm, int x, int y, int width, int height) {
Method repaint
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public void repaint(long tm, int x, int y, int width, int height) {
Method setValueAt
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public void setValueAt(Object aValue, int rowIndex, int columnIndex) {
Feature feature = (Feature)featureList.get(rowIndex);
if(targetFeatures == null) {
targetFeatures = Factory.newFeatureMap();
populate();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Identical blocks of code found in 2 locations. Consider refactoring. Open
case VALUE_COL:
if(feature.value instanceof List) {
listItems.setText(feature.value.toString());
return listPanel;
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 46.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
case VALUE_COL:
if(feature.value instanceof List) {
listItems.setText(feature.value.toString());
return listPanel;
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 46.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76