Sign upLogin

Lesterpig/openparty

View on GitHub
Star
lib/rooms.js

Summary

Maintainability
D
2 days
Test Coverage

File rooms.js has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var utils   = require('./utils.js');
var players = require('./players.js');
var Player  = players.Player;
Severity: Minor
Found in lib/rooms.js - About 3 hrs to fix

    Function sendMessage has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    Room.prototype.sendMessage = function(channel, message, socket) {
  var allowed = false;

  if(channel === 'preChat') {
    if(this.started) {
    Severity: Minor
    Found in lib/rooms.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function leaveRoom has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      leaveRoom: function(socket) {

    var room = socket.currentRoom;
    if(!room) {
      return;
    Severity: Minor
    Found in lib/rooms.js - About 1 hr to fix

      Function leaveRoom has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        leaveRoom: function(socket) {

    var room = socket.currentRoom;
    if(!room) {
      return;
      Severity: Minor
      Found in lib/rooms.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getPublicInfo has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Room.prototype.getPublicInfo = function() {
  var output = {};

  output.id       = this.id;
  output.isRoom   = true;
      Severity: Minor
      Found in lib/rooms.js - About 1 hr to fix

        Function createRoom has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          createRoom: function(name, password, type, socket) {

    if(__conf.maxRooms && this.rooms.length >= __conf.maxRooms) {
      return;
    }
        Severity: Minor
        Found in lib/rooms.js - About 1 hr to fix

          Function createRoom has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            createRoom: function(name, password, type, socket) {

    if(__conf.maxRooms && this.rooms.length >= __conf.maxRooms) {
      return;
    }
          Severity: Minor
          Found in lib/rooms.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function joinRoom has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            joinRoom: function(id, password, socket) {

    var room = this.getRoom(id);
    if(!room) {
      return;
          Severity: Minor
          Found in lib/rooms.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function playerInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          Room.prototype.playerInfo = function(channel, player, value) {

  if(!value) {
    if(channel instanceof Player) {
      channel = channel.socket;
          Severity: Minor
          Found in lib/rooms.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          Room.prototype.resolveUsername = function(username) {
  for(var i = 0; i < this.players.length; i++) {
    if(this.players[i].username === username) {
      return this.players[i];
    }
          Severity: Major
          Found in lib/rooms.js and 1 other location - About 2 hrs to fix
          lib/rooms.js on lines 333..343

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            getRoom: function(id) {

    for(var i = 0; i < this.rooms.length; i++) {
      if(this.rooms[i].id === id) {
        return this.rooms[i];
          Severity: Major
          Found in lib/rooms.js and 1 other location - About 2 hrs to fix
          lib/rooms.js on lines 267..274

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status