Sign upLogin

Leuchtfeuer/auth0-for-typo3

View on GitHub
Star

Showing 31 of 31 total issues

Function getRedirectUri has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

    public function getRedirectUri(array $allowedRedirects): array
    {
        $redirect_url = [];

        if ($this->settings['redirectMode']) {
Severity: Minor
Found in Classes/Service/RedirectService.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getRedirectUri has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getRedirectUri(array $allowedRedirects): array
    {
        $redirect_url = [];

        if ($this->settings['redirectMode']) {
Severity: Major
Found in Classes/Service/RedirectService.php - About 3 hrs to fix

    File AuthenticationService.php has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

declare(strict_types=1);

/*
    Severity: Minor
    Found in Classes/Service/AuthenticationService.php - About 2 hrs to fix

      Application has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Application extends AbstractEntity
{
    public const ALG_HS256 = 'HS256';
    public const ALG_RS256 = 'RS256';
      Severity: Minor
      Found in Classes/Domain/Model/Application.php - About 2 hrs to fix

        Function isInLocalDomain has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function isInLocalDomain(string $url): bool
    {
        if (GeneralUtility::isValidUrl($url)) {
            $parsedUrl = parse_url($url);
            if ($parsedUrl['scheme'] === 'http' || $parsedUrl['scheme'] === 'https') {
        Severity: Minor
        Found in Classes/Service/RedirectService.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method buildDefaultConfiguration has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function buildDefaultConfiguration(): array
    {
        $configuration = [
            'properties' => [
                'fe_users' => [
        Severity: Minor
        Found in Classes/Configuration/Auth0Configuration.php - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          foreach ($GLOBALS['TCA']['fe_users']['types'] ?? [] as $type => $_) {
    $showitem = trim($GLOBALS['TCA']['fe_users']['types'][$type]['showitem']);
    $showitem = sprintf('%s,%s', rtrim($showitem, ','), $auth0Showitem);
    $GLOBALS['TCA']['fe_users']['types'][$type]['showitem'] = $showitem;
}
          Severity: Major
          Found in Configuration/TCA/Overrides/fe_users.php and 1 other location - About 1 hr to fix
          Configuration/TCA/Overrides/be_users.php on lines 27..31

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          foreach ($GLOBALS['TCA']['be_users']['types'] ?? [] as $type => $_) {
    $showitem = trim($GLOBALS['TCA']['be_users']['types'][$type]['showitem']);
    $showitem = sprintf('%s,%s', rtrim($showitem, ','), $auth0Showitem);
    $GLOBALS['TCA']['be_users']['types'][$type]['showitem'] = $showitem;
}
          Severity: Major
          Found in Configuration/TCA/Overrides/be_users.php and 1 other location - About 1 hr to fix
          Configuration/TCA/Overrides/fe_users.php on lines 49..53

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function getColumnsFromTable has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getColumnsFromTable(string $tableName): array
    {
        $columns = [];

        foreach ($GLOBALS['TCA'][$tableName]['columns'] ?? [] as $name => $column) {
          Severity: Minor
          Found in Classes/Utility/TcaUtility.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          <?php
declare(strict_types = 1);

use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
use Leuchtfeuer\Auth0\Domain\Repository\UserGroup\BackendUserGroupRepository;
          Severity: Major
          Found in Configuration/TCA/Overrides/be_groups.php and 1 other location - About 1 hr to fix
          Configuration/TCA/Overrides/fe_groups.php on lines 1..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 112.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          <?php
declare(strict_types = 1);

use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
use Leuchtfeuer\Auth0\Domain\Repository\UserGroup\FrontendUserGroupRepository;
          Severity: Major
          Found in Configuration/TCA/Overrides/fe_groups.php and 1 other location - About 1 hr to fix
          Configuration/TCA/Overrides/be_groups.php on lines 1..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 112.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method createMenu has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function createMenu(ModuleTemplate $moduleTemplate): void
    {
        $menu = $moduleTemplate->getDocHeaderComponent()->getMenuRegistry()->makeMenu();
        $menu->setIdentifier('auth0');
          Severity: Minor
          Found in Classes/Controller/BackendController.php - About 1 hr to fix

            Function findModified has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function findModified(array $currentConfiguration, array $newConfiguration): array
    {
        $differences = [];

        foreach ($newConfiguration as $key => $value) {
            Severity: Minor
            Found in Classes/Configuration/Auth0Configuration.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function handleFrontendCallback has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function handleFrontendCallback(ServerRequestInterface $request, DataSet $tokenDataSet): RedirectResponse
    {
        $errorCode = (string)GeneralUtility::_GET('error');

        if (!empty($errorCode)) {
            Severity: Minor
            Found in Classes/Middleware/CallbackMiddleware.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method build has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function build(int $applicationId, string $context = self::SESSION_PREFIX_BACKEND): Auth0
    {
        $scope = ['openid', 'profile', 'read:current_user'];
        $application = GeneralUtility::makeInstance(ApplicationRepository::class)->findByUid($applicationId);
            Severity: Minor
            Found in Classes/Factory/ApplicationFactory.php - About 1 hr to fix

              Function mapUserData has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function mapUserData(array &$updates, array $mappingConfiguration): void
    {
        $parseFuncUtility = GeneralUtility::makeInstance(ParseFuncUtility::class);

        foreach ($mappingConfiguration as $configurationType => $properties) {
              Severity: Minor
              Found in Classes/Utility/Database/UpdateUtility.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                                              if ($row) {
                                    $redirect_url[] = $this->pi_getPageLink($row['felogin_redirectPid']);
                                }
              Severity: Major
              Found in Classes/Service/RedirectService.php - About 45 mins to fix

                Function findRemoved has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function findRemoved(array $currentConfiguration, array $newConfiguration): array
    {
        $removed = [];

        foreach ($currentConfiguration as $key => $value) {
                Severity: Minor
                Found in Classes/Configuration/Auth0Configuration.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method addButton has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    protected function addButton(string $label, string $actionName, string $controllerName, string $icon, ModuleTemplate $moduleTemplate): void
                Severity: Minor
                Found in Classes/Controller/BackendController.php - About 35 mins to fix

                  Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          ApplicationRepository $applicationRepository,
        ModuleTemplateFactory $moduleTemplateFactory,
        IconFactory $iconFactory,
        UriBuilder $uriBuilder,
        BackendUriBuilder $backendUriBuilder
                  Severity: Minor
                  Found in Classes/Controller/BackendController.php - About 35 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language