Showing 27 of 31 total issues
Function getRedirectUri
has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring. Open
public function getRedirectUri(array $allowedRedirects): array
{
$redirect_url = [];
if ($this->settings['redirectMode']) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getRedirectUri
has 93 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function getRedirectUri(array $allowedRedirects): array
{
$redirect_url = [];
if ($this->settings['redirectMode']) {
File AuthenticationService.php
has 262 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
declare(strict_types=1);
/*
Application
has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class Application extends AbstractEntity
{
public const ALG_HS256 = 'HS256';
public const ALG_RS256 = 'RS256';
Function isInLocalDomain
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
protected function isInLocalDomain(string $url): bool
{
if (GeneralUtility::isValidUrl($url)) {
$parsedUrl = parse_url($url);
if ($parsedUrl['scheme'] === 'http' || $parsedUrl['scheme'] === 'https') {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method buildDefaultConfiguration
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function buildDefaultConfiguration(): array
{
$configuration = [
'properties' => [
'fe_users' => [
Function getColumnsFromTable
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function getColumnsFromTable(string $tableName): array
{
$columns = [];
foreach ($GLOBALS['TCA'][$tableName]['columns'] ?? [] as $name => $column) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method createMenu
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function createMenu(ModuleTemplate $moduleTemplate): void
{
$menu = $moduleTemplate->getDocHeaderComponent()->getMenuRegistry()->makeMenu();
$menu->setIdentifier('auth0');
Function findModified
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function findModified(array $currentConfiguration, array $newConfiguration): array
{
$differences = [];
foreach ($newConfiguration as $key => $value) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function handleFrontendCallback
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function handleFrontendCallback(ServerRequestInterface $request, DataSet $tokenDataSet): RedirectResponse
{
$errorCode = (string)GeneralUtility::_GET('error');
if (!empty($errorCode)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method build
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function build(int $applicationId, string $context = self::SESSION_PREFIX_BACKEND): Auth0
{
$scope = ['openid', 'profile', 'read:current_user'];
$application = GeneralUtility::makeInstance(ApplicationRepository::class)->findByUid($applicationId);
Function mapUserData
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
protected function mapUserData(array &$updates, array $mappingConfiguration): void
{
$parseFuncUtility = GeneralUtility::makeInstance(ParseFuncUtility::class);
foreach ($mappingConfiguration as $configurationType => $properties) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function findRemoved
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function findRemoved(array $currentConfiguration, array $newConfiguration): array
{
$removed = [];
foreach ($currentConfiguration as $key => $value) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid deeply nested control flow statements. Open
if ($row) {
$redirect_url[] = $this->pi_getPageLink($row['felogin_redirectPid']);
}
Method addButton
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
protected function addButton(string $label, string $actionName, string $controllerName, string $icon, ModuleTemplate $moduleTemplate): void
Method __construct
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
ApplicationRepository $applicationRepository,
ModuleTemplateFactory $moduleTemplateFactory,
IconFactory $iconFactory,
UriBuilder $uriBuilder,
BackendUriBuilder $backendUriBuilder
Function setIssuer
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function setIssuer(): void
{
if (!ModeUtility::isBackend()) {
try {
if (!isset($GLOBALS['TSFE'])) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function mapRoles
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
protected function mapRoles(array $groupMapping, array &$groupsToAssign, bool &$isBeAdmin, bool &$shouldUpdate): void
{
$rolesKey = $this->yamlConfiguration['roles']['key'] ?? 'roles';
$roles = (array)$this->user['app_metadata'][$rolesKey] ?? [];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function deleteAction
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function deleteAction(array $property, string $table, string $type): ResponseInterface
{
if ((bool)$property['readOnly'] === false) {
$auth0Configuration = GeneralUtility::makeInstance(Auth0Configuration::class);
$configuration = $auth0Configuration->load();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return $this->handleFrontendCallback($request, $dataSet);