Leuchtfeuer/auth0-for-typo3

View on GitHub

Showing 27 of 31 total issues

Function getRedirectUri has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

    public function getRedirectUri(array $allowedRedirects): array
    {
        $redirect_url = [];

        if ($this->settings['redirectMode']) {
Severity: Minor
Found in Classes/Service/RedirectService.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getRedirectUri has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getRedirectUri(array $allowedRedirects): array
    {
        $redirect_url = [];

        if ($this->settings['redirectMode']) {
Severity: Major
Found in Classes/Service/RedirectService.php - About 3 hrs to fix

    File AuthenticationService.php has 262 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    declare(strict_types=1);
    
    /*
    Severity: Minor
    Found in Classes/Service/AuthenticationService.php - About 2 hrs to fix

      Application has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Application extends AbstractEntity
      {
          public const ALG_HS256 = 'HS256';
          public const ALG_RS256 = 'RS256';
      
      
      Severity: Minor
      Found in Classes/Domain/Model/Application.php - About 2 hrs to fix

        Function isInLocalDomain has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function isInLocalDomain(string $url): bool
            {
                if (GeneralUtility::isValidUrl($url)) {
                    $parsedUrl = parse_url($url);
                    if ($parsedUrl['scheme'] === 'http' || $parsedUrl['scheme'] === 'https') {
        Severity: Minor
        Found in Classes/Service/RedirectService.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method buildDefaultConfiguration has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function buildDefaultConfiguration(): array
            {
                $configuration = [
                    'properties' => [
                        'fe_users' => [
        Severity: Minor
        Found in Classes/Configuration/Auth0Configuration.php - About 1 hr to fix

          Function getColumnsFromTable has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getColumnsFromTable(string $tableName): array
              {
                  $columns = [];
          
                  foreach ($GLOBALS['TCA'][$tableName]['columns'] ?? [] as $name => $column) {
          Severity: Minor
          Found in Classes/Utility/TcaUtility.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method createMenu has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function createMenu(ModuleTemplate $moduleTemplate): void
              {
                  $menu = $moduleTemplate->getDocHeaderComponent()->getMenuRegistry()->makeMenu();
                  $menu->setIdentifier('auth0');
          
          
          Severity: Minor
          Found in Classes/Controller/BackendController.php - About 1 hr to fix

            Function findModified has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function findModified(array $currentConfiguration, array $newConfiguration): array
                {
                    $differences = [];
            
                    foreach ($newConfiguration as $key => $value) {
            Severity: Minor
            Found in Classes/Configuration/Auth0Configuration.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function handleFrontendCallback has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function handleFrontendCallback(ServerRequestInterface $request, DataSet $tokenDataSet): RedirectResponse
                {
                    $errorCode = (string)GeneralUtility::_GET('error');
            
                    if (!empty($errorCode)) {
            Severity: Minor
            Found in Classes/Middleware/CallbackMiddleware.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method build has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function build(int $applicationId, string $context = self::SESSION_PREFIX_BACKEND): Auth0
                {
                    $scope = ['openid', 'profile', 'read:current_user'];
                    $application = GeneralUtility::makeInstance(ApplicationRepository::class)->findByUid($applicationId);
            
            
            Severity: Minor
            Found in Classes/Factory/ApplicationFactory.php - About 1 hr to fix

              Function mapUserData has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function mapUserData(array &$updates, array $mappingConfiguration): void
                  {
                      $parseFuncUtility = GeneralUtility::makeInstance(ParseFuncUtility::class);
              
                      foreach ($mappingConfiguration as $configurationType => $properties) {
              Severity: Minor
              Found in Classes/Utility/Database/UpdateUtility.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function findRemoved has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function findRemoved(array $currentConfiguration, array $newConfiguration): array
                  {
                      $removed = [];
              
                      foreach ($currentConfiguration as $key => $value) {
              Severity: Minor
              Found in Classes/Configuration/Auth0Configuration.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                                              if ($row) {
                                                  $redirect_url[] = $this->pi_getPageLink($row['felogin_redirectPid']);
                                              }
              Severity: Major
              Found in Classes/Service/RedirectService.php - About 45 mins to fix

                Method addButton has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    protected function addButton(string $label, string $actionName, string $controllerName, string $icon, ModuleTemplate $moduleTemplate): void
                Severity: Minor
                Found in Classes/Controller/BackendController.php - About 35 mins to fix

                  Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          ApplicationRepository $applicationRepository,
                          ModuleTemplateFactory $moduleTemplateFactory,
                          IconFactory $iconFactory,
                          UriBuilder $uriBuilder,
                          BackendUriBuilder $backendUriBuilder
                  Severity: Minor
                  Found in Classes/Controller/BackendController.php - About 35 mins to fix

                    Function setIssuer has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function setIssuer(): void
                        {
                            if (!ModeUtility::isBackend()) {
                                try {
                                    if (!isset($GLOBALS['TSFE'])) {
                    Severity: Minor
                    Found in Classes/Utility/TokenUtility.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function mapRoles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function mapRoles(array $groupMapping, array &$groupsToAssign, bool &$isBeAdmin, bool &$shouldUpdate): void
                        {
                            $rolesKey = $this->yamlConfiguration['roles']['key'] ?? 'roles';
                            $roles = (array)$this->user['app_metadata'][$rolesKey] ?? [];
                    
                    
                    Severity: Minor
                    Found in Classes/Utility/Database/UpdateUtility.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function deleteAction has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function deleteAction(array $property, string $table, string $type): ResponseInterface
                        {
                            if ((bool)$property['readOnly'] === false) {
                                $auth0Configuration = GeneralUtility::makeInstance(Auth0Configuration::class);
                                $configuration = $auth0Configuration->load();
                    Severity: Minor
                    Found in Classes/Controller/PropertyController.php - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                            return $this->handleFrontendCallback($request, $dataSet);
                    Severity: Major
                    Found in Classes/Middleware/CallbackMiddleware.php - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language