Sign upLogin

Leuchtfeuer/locate

View on GitHub
Star
Classes/Verdict/Redirect.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method redirectToPage has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function redirectToPage(): ?RedirectResponse
    {
        $pageId = (int)($this->configuration['page'] ?? $GLOBALS['TYPO3_REQUEST']->getAttribute('routing')->getPageId());
        $targetLanguageId = isset($this->configuration['sys_language']) ? (int)$this->configuration['sys_language'] : 0;
        $page = BackendUtility::getRecord('pages', $pageId, '*', '', false);
Severity: Minor
Found in Classes/Verdict/Redirect.php - About 1 hr to fix

    Function handleSessionStuff has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function handleSessionStuff(): void
    {
        $currentLanguageUid = $this->requestedLanguageUid;

        if ($this->isSessionValueSet()) {
    Severity: Minor
    Found in Classes/Verdict/Redirect.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function redirectToPage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function redirectToPage(): ?RedirectResponse
    {
        $pageId = (int)($this->configuration['page'] ?? $GLOBALS['TYPO3_REQUEST']->getAttribute('routing')->getPageId());
        $targetLanguageId = isset($this->configuration['sys_language']) ? (int)$this->configuration['sys_language'] : 0;
        $page = BackendUtility::getRecord('pages', $pageId, '*', '', false);
    Severity: Minor
    Found in Classes/Verdict/Redirect.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function shouldRedirect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function shouldRedirect(): bool
    {
        // Always redirect when we are not in session mode
        if ($this->sessionMode === false) {
            return true;
    Severity: Minor
    Found in Classes/Verdict/Redirect.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status