Sign upLogin

Leuchtfeuer/mautic-deutschepost

View on GitHub
Star
Service/PrintmailingService.php

Summary

Maintainability
D
1 day
Test Coverage

File PrintmailingService.php has 427 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace MauticPlugin\LeuchtfeuerPrintmailingBundle\Service;

use GuzzleHttp\Client;
Severity: Minor
Found in Service/PrintmailingService.php - About 6 hrs to fix

    PrintmailingService has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class PrintmailingService
{
    public const LOCALE = 'de';

    public const SESSION_KEY = 'printmailing';
    Severity: Minor
    Found in Service/PrintmailingService.php - About 2 hrs to fix

      Method listCampaigns has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function listCampaigns(int $offset = 0, int $pageNumber = 0, int $pageSize = 10, bool $paged = true, bool $unpaged = false, bool $forceFirstAndLastRels = false): array
      Severity: Minor
      Found in Service/PrintmailingService.php - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function createVariableDefinitions(TriggerCampaign $triggerCampaign): void
    {
        $response = $this->client->request(
            'POST',
            sprintf('/post/advertising/print-mailing/automation/v1/mailings/%d/variabledefinitions', $triggerCampaign->getMailingId()),
        Severity: Major
        Found in Service/PrintmailingService.php and 1 other location - About 1 hr to fix
        Service/PrintmailingService.php on lines 313..332

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function updateCampaignVariable(TriggerCampaign $triggerCampaign): void
    {
        $response = $this->client->request(
            'PUT',
            sprintf('/post/advertising/print-mailing/automation/v1/mailings/%d/variabledefinitions', $triggerCampaign->getMailingId()),
        Severity: Major
        Found in Service/PrintmailingService.php and 1 other location - About 1 hr to fix
        Service/PrintmailingService.php on lines 292..311

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status