Sign upLogin

Leuchtfeuer/typo3-secure-downloads

View on GitHub
Star
Classes/Resource/FileDelivery.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method deliver has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function deliver(string $jsonWebToken, ServerRequestInterface $request): ResponseInterface
    {
        if (!$this->retrieveDataFromJsonWebToken($jsonWebToken)) {
            return $this->getAccessDeniedResponse($request, 'Could not parse token.');
        }
Severity: Minor
Found in Classes/Resource/FileDelivery.php - About 1 hr to fix

    Method dispatchBeforeFileDeliverEvent has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string &$outputFunction,
        array &$header,
        string $fileName,
        string $mimeType,
        bool $forceDownload
    Severity: Minor
    Found in Classes/Resource/FileDelivery.php - About 35 mins to fix

      Function deliver has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function deliver(string $jsonWebToken, ServerRequestInterface $request): ResponseInterface
    {
        if (!$this->retrieveDataFromJsonWebToken($jsonWebToken)) {
            return $this->getAccessDeniedResponse($request, 'Could not parse token.');
        }
      Severity: Minor
      Found in Classes/Resource/FileDelivery.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $this->getFileNotFoundResponse($request, 'File does not exist!');
      Severity: Major
      Found in Classes/Resource/FileDelivery.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status