Library-Distribution/ALD.rb

View on GitHub

Showing 8 of 8 total issues

Method [] has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def [](*args)
        if args.length == 1 && args.first.is_a?(Integer)
          request unless initialized?
          entry(@data[args.first])
        else
Severity: Minor
Found in lib/ALD/collection.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method range_condition_queries has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def range_condition_queries(conds)
        Hash[
          present_conditions(conds).map { |cond|
            fields = @conditions[cond.to_sym].is_a?(Array) ? @conditions[cond.to_sym] : [@conditions[cond.to_sym]]
            fields.map do |field|
Severity: Minor
Found in lib/ALD/conditioned.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method merge_ranges has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

      def merge_ranges(key, old, new)
        constraints = [new, old]
        data = constraints.map do |c|
          match = RANGE_REGEX.match(c)
          if match.nil?
Severity: Minor
Found in lib/ALD/conditioned.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def request(url, method = :get, headers = {}, body = nil)
      Net::HTTP.start(@root_url.host, @root_url.port) do |http|
        url = @root_url + url

        request = create_request(method, url)
Severity: Minor
Found in lib/ALD/api.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method item has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def item(*args)
      if args.first.is_a? Hash # used internally to avoid multiple Item instances
        args.first['id'] = normalize_id(args.first['id'])
        @item_store[args.first['id']] ||= Item.new(self, *args)
      elsif args.length == 1 && args.first.is_a?(String) # GUID
Severity: Minor
Found in lib/ALD/api.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method user has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def user(*args)
      if args.first.is_a? Hash # used internally to avoid multiple User instances
        args.first['id'] = normalize_id(args.first['id'])
        @user_store[args.first['id']] ||= User.new(self, *args)
      elsif args.length == 1 && args.first.is_a?(String)
Severity: Minor
Found in lib/ALD/api.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method merge_conditions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def merge_conditions(conditions)
        @conditions.merge(conditions) do |key, old_value, new_value|
          if self.class::RANGE_CONDITIONS.include?(key.to_s)
            merge_ranges(key, old_value, new_value) # handle merging for cases like 'downloads >= 5' and 'downloads <= 9' etc.
          elsif self.class::ARRAY_CONDITIONS.include?(key.to_s)
Severity: Minor
Found in lib/ALD/conditioned.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sortings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def self.sortings(sort, a, b)
          sort.map do |key, dir|
            key = key.to_s
            if key == 'version'
              result = Semantic::Version.new(a[key]) <=> Semantic::Version.new(b[key])
Severity: Minor
Found in lib/ALD/local_filter.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language