Sign upLogin

Lichess4545/Chesster

View on GitHub
Star

Showing 173 of 173 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                    if (!this.fullyQuit) {
                        this.log.info(`Restarting watcher`)
                        this.watch()
                    } else {
                        this.log.info(
Severity: Major
Found in src/watcher.ts and 1 other location - About 1 hr to fix
src/watcher.ts on lines 156..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (
        black.tz &&
        moment().tz(black.tz).utcOffset() !== blackDate.utcOffset()
    ) {
        dateFormats +=
Severity: Major
Found in src/commands/scheduling.ts and 1 other location - About 1 hr to fix
src/commands/scheduling.ts on lines 448..456

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 67.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export function availability(bot: SlackBot, message: LeagueCommandMessage) {
    bot.reply(
        message,
        `Use this link to set your availability: ${message.league.config.links.availability}`
    )
Severity: Major
Found in src/commands/privateURLs.ts and 2 other locations - About 1 hr to fix
src/commands/privateURLs.ts on lines 10..15
src/commands/privateURLs.ts on lines 18..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export function nomination(bot: SlackBot, message: LeagueCommandMessage) {
    bot.reply(
        message,
        `Use this link to nominate your choice: ${message.league.config.links.nominate}`
    )
Severity: Major
Found in src/commands/privateURLs.ts and 2 other locations - About 1 hr to fix
src/commands/privateURLs.ts on lines 18..23
src/commands/privateURLs.ts on lines 26..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export function notification(bot: SlackBot, message: LeagueCommandMessage) {
    bot.reply(
        message,
        `Use this link to set your notifications preferences: ${message.league.config.links.notifications}`
    )
Severity: Major
Found in src/commands/privateURLs.ts and 2 other locations - About 1 hr to fix
src/commands/privateURLs.ts on lines 10..15
src/commands/privateURLs.ts on lines 26..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function watch has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    watch() {
        const newUsernames = _.uniq(
            fp
                .flatMap((l) => l._pairings, this.leagues)
                .flatMap((p: Pairing) => [p.white, p.black])
Severity: Minor
Found in src/watcher.ts - About 1 hr to fix

    Function playerPairings has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function playerPairings(
    bot: SlackBot,
    message: CommandMessage
): Promise<void> {
    const targetPlayer = bot.getLeagueMemberTarget(message)
    Severity: Minor
    Found in src/commands/playerInfo.ts - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      function schedulingReplyMissingPairing(
    bot: SlackBot,
    message: LeagueCommandMessage
) {
    const user = '<@' + message.user + '>'
      Severity: Major
      Found in src/commands/scheduling.ts and 2 other locations - About 1 hr to fix
      src/commands/scheduling.ts on lines 368..376
      src/commands/scheduling.ts on lines 489..500

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      function schedulingReplyCantScheduleOthers(
    bot: SlackBot,
    message: LeagueCommandMessage
) {
    const user = '<@' + message.user + '>'
      Severity: Major
      Found in src/commands/scheduling.ts and 2 other locations - About 1 hr to fix
      src/commands/scheduling.ts on lines 368..376
      src/commands/scheduling.ts on lines 379..390

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      function replyNoActiveRound(bot: SlackBot, message: LeagueCommandMessage) {
    const user = '<@' + message.user + '>'
    bot.reply(
        message,
        ':x: ' +
      Severity: Major
      Found in src/commands/scheduling.ts and 2 other locations - About 1 hr to fix
      src/commands/scheduling.ts on lines 379..390
      src/commands/scheduling.ts on lines 489..500

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              } else if (error instanceof commands.InvalidTypeValueError) {
            winston.debug(
                `[ASSIGNMENT] Couldn't understand: ${JSON.stringify(error)}`
            )
            replyMisunderstoodAlternateAssignment(bot, message)
      Severity: Major
      Found in src/commands/availability.ts and 1 other location - About 1 hr to fix
      src/commands/messageForwarding.ts on lines 77..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function updatePairing has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export async function updatePairing(
    heltourConfig: LeagueConfig,
    result: UpdatePairingRequest
) {
    const pairings = await findPairing(
      Severity: Minor
      Found in src/heltour.ts - About 1 hr to fix

        Function validateUserResult has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function validateUserResult(details: lichess.GameDetails, result: Result) {
    // if colors are reversed, in the game link, we will catch that later
    // we know the players are correct or we would not already be here
    // the only way we can validate the result is if the order is 100% correct.
    const validity = {
        Severity: Minor
        Found in src/commands/games.ts - About 1 hr to fix

          Function refresh has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              refresh() {
        return Promise.all([
            this.refreshRosters()
                .then(() => {
                    this._lastUpdated = moment.utc()
          Severity: Minor
          Found in src/league.ts - About 1 hr to fix

            Function handleMatch has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                async handleMatch(
        listener: SlackRTMEventListenerOptions,
        message: CommandMessage
    ) {
        let allowedTypes = ['command', 'league_command']
            Severity: Minor
            Found in src/slack.ts - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function register has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function register(bot: SlackBot, eventName: string, cb: Callback) {
    // Ensure this is a known event.
    events.push(eventName)

    // Handle the event when it happens
            Severity: Minor
            Found in src/commands/subscription.ts - About 1 hr to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          links: {
                faq: 'https://www.lichess4545.com/blitzbattle/document/faq/',
                rules:
                    'https://www.lichess4545.com/blitzbattle/document/rules/',
                league: 'https://www.lichess4545.com/blitzbattle/',
              Severity: Major
              Found in config/config.js and 3 other locations - About 1 hr to fix
              config/config.js on lines 92..108
              config/config.js on lines 148..162
              config/config.js on lines 256..270

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          links: {
                faq: 'https://www.lichess4545.com/chess960/document/faq/',
                rules: 'https://www.lichess4545.com/chess960/document/rules/',
                league: 'https://www.lichess4545.com/chess960/',
                pairings: 'https://www.lichess4545.com/chess960/pairings/',
              Severity: Major
              Found in config/config.js and 3 other locations - About 1 hr to fix
              config/config.js on lines 92..108
              config/config.js on lines 148..162
              config/config.js on lines 200..216

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          links: {
                faq: 'https://www.lichess4545.com/lonewolf/document/faq/',
                rules: 'https://www.lichess4545.com/lonewolf/document/rules/',
                league: 'https://www.lichess4545.com/lonewolf/',
                pairings: 'https://www.lichess4545.com/lonewolf/pairings/',
              Severity: Major
              Found in config/config.js and 3 other locations - About 1 hr to fix
              config/config.js on lines 92..108
              config/config.js on lines 200..216
              config/config.js on lines 256..270

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          links: {
                faq: 'https://www.lichess4545.com/team4545/document/faq/',
                rules: 'https://www.lichess4545.com/team4545/document/rules/',
                league: 'https://www.lichess4545.com/team4545/',
                pairings: 'https://www.lichess4545.com/team4545/pairings/',
              Severity: Major
              Found in config/config.js and 3 other locations - About 1 hr to fix
              config/config.js on lines 148..162
              config/config.js on lines 200..216
              config/config.js on lines 256..270

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 61.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language