Sign upLogin

Lichess4545/Chesster

View on GitHub
Star

Showing 173 of 173 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            if (
                error instanceof commands.TooFewTokensError ||
                error instanceof commands.InvalidChoiceError ||
                error instanceof commands.InvalidConstantError ||
                error instanceof commands.InvalidTypeValueError
Severity: Minor
Found in src/commands/messageForwarding.ts and 1 other location - About 35 mins to fix
src/commands/availability.ts on lines 234..254

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (
            error instanceof commands.TooFewTokensError ||
            error instanceof commands.InvalidChoiceError ||
            error instanceof commands.InvalidConstantError ||
            error instanceof commands.InvalidTypeValueError
Severity: Minor
Found in src/commands/availability.ts and 1 other location - About 35 mins to fix
src/commands/messageForwarding.ts on lines 77..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

chesster.hears({
    type: 'league_command',
    patterns: [/.*/],
    messageTypes: ['ambient'],
    callback: games.ambientResults,
Severity: Minor
Found in src/chesster.ts and 1 other location - About 35 mins to fix
src/chesster.ts on lines 262..267

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

chesster.hears({
    type: 'league_command',
    patterns: [/.*/],
    messageTypes: ['ambient'],
    callback: scheduling.ambientScheduling,
Severity: Minor
Found in src/chesster.ts and 1 other location - About 35 mins to fix
src/chesster.ts on lines 272..277

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return
Severity: Major
Found in src/commands/scheduling.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return resolve(formatNoTeamResponse())
    Severity: Major
    Found in src/commands/subscription.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return ResultsEnum.UNKNOWN
      Severity: Major
      Found in src/lichess.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return ResultsEnum.SCHEDULING_DRAW
        Severity: Major
        Found in src/league.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return
          Severity: Major
          Found in src/commands/availability.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return
            Severity: Major
            Found in src/commands/scheduling.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return
              Severity: Major
              Found in src/commands/games.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return
                Severity: Major
                Found in src/commands/availability.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return formatNoTeamResponse()
                  Severity: Major
                  Found in src/commands/subscription.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return heltour
        .assignAlternate(
            heltourOptions,
            roundNumber,
            team.number,
                    Severity: Major
                    Found in src/commands/availability.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return await heltour.playerContact(
        bot.config.heltour,
        sender.lichess_username,
        player.lichess_username
    )
                      Severity: Major
                      Found in src/commands/presence.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return
                        Severity: Major
                        Found in src/commands/availability.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return ResultsEnum.UNKNOWN
                          Severity: Major
                          Found in src/league.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                        return team.name + ' has not chosen a team captain. '
                            Severity: Major
                            Found in src/league.ts - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                          return
                              Severity: Major
                              Found in src/commands/availability.ts - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                        return
                                Severity: Major
                                Found in src/commands/games.ts - About 30 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language