Sign upLogin

Lichess4545/Chesster

View on GitHub
Star
src/commands/scheduling.ts

Summary

Maintainability
F
4 days
Test Coverage
F
56%

File scheduling.ts has 558 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// -----------------------------------------------------------------------------
// Commands and helpers for scheduling games
// -----------------------------------------------------------------------------
import moment from 'moment-timezone'
import _ from 'lodash'
Severity: Major
Found in src/commands/scheduling.ts - About 1 day to fix

    Function ambientScheduling has 147 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function ambientScheduling(
    bot: SlackBot,
    message: LeagueCommandMessage
) {
    const league = message.league
    Severity: Major
    Found in src/commands/scheduling.ts - About 5 hrs to fix

      Function ambientScheduling has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

      export async function ambientScheduling(
    bot: SlackBot,
    message: LeagueCommandMessage
) {
    const league = message.league
      Severity: Minor
      Found in src/commands/scheduling.ts - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function parseScheduling has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function parseScheduling(
    inputString: string,
    options: config.Scheduling
): SchedulingResult {
    const parts = getTokensScheduling(inputString)
      Severity: Major
      Found in src/commands/scheduling.ts - About 2 hrs to fix

        Function getPossibleDateStrings has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function getPossibleDateStrings(dateString: string, extrema: Extrema) {
    const dateStrings = []

    // Unify some common stuff first.
    //
        Severity: Major
        Found in src/commands/scheduling.ts - About 2 hrs to fix

          Function schedulingReplyScheduled has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function schedulingReplyScheduled(
    bot: SlackBot,
    message: LeagueCommandMessage,
    results: SchedulingResult,
    white: LeagueMember,
          Severity: Minor
          Found in src/commands/scheduling.ts - About 1 hr to fix

            Function parseScheduling has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

            export function parseScheduling(
    inputString: string,
    options: config.Scheduling
): SchedulingResult {
    const parts = getTokensScheduling(inputString)
            Severity: Minor
            Found in src/commands/scheduling.ts - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function schedulingReplyScheduled has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                bot: SlackBot,
    message: LeagueCommandMessage,
    results: SchedulingResult,
    white: LeagueMember,
    black: LeagueMember,
            Severity: Major
            Found in src/commands/scheduling.ts - About 50 mins to fix

              Function schedulingReplyTooCloseToCutoff has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  bot: SlackBot,
    message: LeagueCommandMessage,
    schedulingOptions: config.Scheduling,
    white: LeagueMember,
    black: LeagueMember
              Severity: Minor
              Found in src/commands/scheduling.ts - About 35 mins to fix

                Avoid too many return statements within this function.
                Open

                        return
                Severity: Major
                Found in src/commands/scheduling.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return
                  Severity: Major
                  Found in src/commands/scheduling.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return
                    Severity: Major
                    Found in src/commands/scheduling.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return
                      Severity: Major
                      Found in src/commands/scheduling.ts - About 30 mins to fix

                        Function getPossibleDateStrings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        function getPossibleDateStrings(dateString: string, extrema: Extrema) {
    const dateStrings = []

    // Unify some common stuff first.
    //
                        Severity: Minor
                        Found in src/commands/scheduling.ts - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if (
        white.tz &&
        moment().tz(white.tz).utcOffset() !== whiteDate.utcOffset()
    ) {
        dateFormats +=
                        Severity: Major
                        Found in src/commands/scheduling.ts and 1 other location - About 1 hr to fix
                        src/commands/scheduling.ts on lines 457..465

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 67.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if (
        black.tz &&
        moment().tz(black.tz).utcOffset() !== blackDate.utcOffset()
    ) {
        dateFormats +=
                        Severity: Major
                        Found in src/commands/scheduling.ts and 1 other location - About 1 hr to fix
                        src/commands/scheduling.ts on lines 448..456

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 67.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                        function schedulingReplyCantScheduleOthers(
    bot: SlackBot,
    message: LeagueCommandMessage
) {
    const user = '<@' + message.user + '>'
                        Severity: Major
                        Found in src/commands/scheduling.ts and 2 other locations - About 1 hr to fix
                        src/commands/scheduling.ts on lines 368..376
                        src/commands/scheduling.ts on lines 379..390

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 65.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                        function replyNoActiveRound(bot: SlackBot, message: LeagueCommandMessage) {
    const user = '<@' + message.user + '>'
    bot.reply(
        message,
        ':x: ' +
                        Severity: Major
                        Found in src/commands/scheduling.ts and 2 other locations - About 1 hr to fix
                        src/commands/scheduling.ts on lines 379..390
                        src/commands/scheduling.ts on lines 489..500

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 65.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 3 locations. Consider refactoring.
                        Open

                        function schedulingReplyMissingPairing(
    bot: SlackBot,
    message: LeagueCommandMessage
) {
    const user = '<@' + message.user + '>'
                        Severity: Major
                        Found in src/commands/scheduling.ts and 2 other locations - About 1 hr to fix
                        src/commands/scheduling.ts on lines 368..376
                        src/commands/scheduling.ts on lines 489..500

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 65.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            blackDate = black.tz
        ? blackDate.tz(black.tz)
        : blackDate.utcOffset(black.tz_offset / 60)
                        Severity: Minor
                        Found in src/commands/scheduling.ts and 1 other location - About 30 mins to fix
                        src/commands/scheduling.ts on lines 434..436

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            whiteDate = white.tz
        ? whiteDate.tz(white.tz)
        : whiteDate.utcOffset(white.tz_offset / 60)
                        Severity: Minor
                        Found in src/commands/scheduling.ts and 1 other location - About 30 mins to fix
                        src/commands/scheduling.ts on lines 437..439

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status