Sign upLogin

Lichess4545/Chesster

View on GitHub
Star
src/lichess.ts

Summary

Maintainability
D
2 days
Test Coverage
D
63%

File lichess.ts has 491 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// -----------------------------------------------------------------------------
// Lichess API helpers
// -----------------------------------------------------------------------------
import * as http from './http'
import moment from 'moment-timezone'
Severity: Minor
Found in src/lichess.ts - About 7 hrs to fix

    Function processRequests has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function processRequests() {
        if (stop) return
        let request = null
        // The default delay between requests is 2 seconds
        let requestDelay = 0
    Severity: Major
    Found in src/lichess.ts - About 3 hrs to fix

      Function gameResult has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      export function gameResult(
    status: GameStatus,
    winner?: GameWinner
): ResultsEnum {
    if (status === GameStatus.draw || status === GameStatus.stalemate) {
      Severity: Minor
      Found in src/lichess.ts - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

              return ResultsEnum.BLACK_WIN
      Severity: Major
      Found in src/lichess.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return ResultsEnum.UNKNOWN
        Severity: Major
        Found in src/lichess.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return ResultsEnum.WHITE_WIN
          Severity: Major
          Found in src/lichess.ts - About 30 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

            export const OpeningDecoder: Decoder<Opening> = object(
    ['eco', string()],
    ['name', string()],
    ['ply', number()],
    (eco, name, ply) => ({ eco, name, ply })
            Severity: Major
            Found in src/lichess.ts and 2 other locations - About 1 hr to fix
            src/config.ts on lines 283..288
            src/heltour.ts on lines 214..223

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

            export const ShortUserDecoder: Decoder<ShortUser> = object(
    ['name', string()],
    ['id', string()],
    (name, id) => ({ name, id })
)
            Severity: Major
            Found in src/lichess.ts and 3 other locations - About 1 hr to fix
            src/config.ts on lines 26..30
            src/config.ts on lines 52..56
            src/config.ts on lines 62..66

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 56.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            export const GameDetailsWithClockDecoder: Decoder<GameDetails> = andThen(
    BaseGameDetailsDecoder,
    (gameDetails) =>
        object(['clock', ClockDecoder], (clock) => ({ ...gameDetails, clock }))
)
            Severity: Minor
            Found in src/lichess.ts and 1 other location - About 45 mins to fix
            src/config.ts on lines 220..227

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status