Sign upLogin

Lichess4545/Chesster

View on GitHub
Star
src/watcher.ts

Summary

Maintainability
D
2 days
Test Coverage

Function processGameDetails has 147 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async processGameDetails(details: lichess.GameDetails) {
        fp.each(async (league) => {
            // 1. perfect match any time, try to update.
            // 2. pairing + time control match any time, warn for other mismatches
            // 3. pairing match during a 4 hour window (+-2 hours), warn for other mismatches
Severity: Major
Found in src/watcher.ts - About 5 hrs to fix

    File watcher.ts has 384 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // -----------------------------------------------------------------------------
// Watcher uses the game-stream API from Lichess to listen for games as they
// start and end.
// -----------------------------------------------------------------------------
    Severity: Minor
    Found in src/watcher.ts - About 5 hrs to fix

      Function watch has 104 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          watch() {
        if (this.stop()) {
            return // The .on('end') handler will restart us.
        }
      Severity: Major
      Found in src/watcher.ts - About 4 hrs to fix

        Function watch has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            watch() {
        const newUsernames = _.uniq(
            fp
                .flatMap((l) => l._pairings, this.leagues)
                .flatMap((p: Pairing) => [p.white, p.black])
        Severity: Minor
        Found in src/watcher.ts - About 1 hr to fix

          Function watch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              watch() {
        const newUsernames = _.uniq(
            fp
                .flatMap((l) => l._pairings, this.leagues)
                .flatMap((p: Pairing) => [p.white, p.black])
          Severity: Minor
          Found in src/watcher.ts - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (!this.fullyQuit) {
                        this.log.info(`Restarting watcher`)
                        this.watch()
                    } else {
                        this.log.info(
          Severity: Major
          Found in src/watcher.ts and 1 other location - About 1 hr to fix
          src/watcher.ts on lines 156..163

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                              if (!this.fullyQuit) {
                        this.log.info(`Restarting watcher`)
                        this.watch()
                    } else {
                        this.log.info(
          Severity: Major
          Found in src/watcher.ts and 1 other location - About 1 hr to fix
          src/watcher.ts on lines 139..146

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status